Issue 1547 - Pass isolate to v8::API

- add isolate argument to Utils::ToV8String and fix calls of the function
- replace v8::String::New calls by Utils::ToV8String
- pass isolate to v8::Number::New

# Works on MSVS{2010,2012}, gcc-4.8.2 64bit

[Wladimir Palant, 2014-11-11 20:46:38]

LGTM

[Felix Dahlke, 2015-02-05 04:58:24]

Sorry for the delay! Looks good, just a few small comments.

http://codereview.adblockplus.org/6112412478472192/diff/5629499534213120/src/...
File src/GlobalJsObject.cpp (right):

http://codereview.adblockplus.org/6112412478472192/diff/5629499534213120/src/...
src/GlobalJsObject.cpp:71: v8::Isolate* isolate = arguments.GetIsolate();
I think we should move this to the catch block where it's used to keep the scope
small - or just inline arguments.GetIsolate().

http://codereview.adblockplus.org/6112412478472192/diff/5629499534213120/src/...
src/GlobalJsObject.cpp:96: v8::Isolate* isolate = arguments.GetIsolate();
Same here, we only need it if converted.size() < 1.

http://codereview.adblockplus.org/6112412478472192/diff/5629499534213120/src/...
File src/WebRequestJsObject.cpp (right):

http://codereview.adblockplus.org/6112412478472192/diff/5629499534213120/src/...
src/WebRequestJsObject.cpp:95: v8::Isolate* isolate = arguments.GetIsolate();
Unnecessarily large scope again.

[sergei, 2015-02-05 16:03:15]

On 2015/02/05 04:58:24, Felix H. Dahlke wrote:
> src/WebRequestJsObject.cpp:95: v8::Isolate* isolate = arguments.GetIsolate();
> Unnecessarily large scope again.

I've moved it into the scope, however I have not inlined it because we will need
`isolate` to throw the exception because in the recent version of v8
`ThrowException` is the member of v8::Isolate.

[Felix Dahlke, 2015-02-06 04:17:27]

Looks good, but now there are some unrelated whitespace changes in the patch
set.

http://codereview.adblockplus.org/6112412478472192/diff/5738600293466112/src/...
File src/GlobalJsObject.cpp (right):

http://codereview.adblockplus.org/6112412478472192/diff/5738600293466112/src/...
src/GlobalJsObject.cpp:70: 
Unrelated change.

http://codereview.adblockplus.org/6112412478472192/diff/5738600293466112/src/...
src/GlobalJsObject.cpp:95: 
Also unrelated.

http://codereview.adblockplus.org/6112412478472192/diff/5738600293466112/src/...
File src/WebRequestJsObject.cpp (right):

http://codereview.adblockplus.org/6112412478472192/diff/5738600293466112/src/...
src/WebRequestJsObject.cpp:94: 
Unrelated as well.

[sergei, 2015-02-09 11:04:09]

On 2015/02/06 04:17:27, Felix H. Dahlke wrote:
> Looks good, but now there are some unrelated whitespace changes in the patch
> set.
fixed

[Felix Dahlke, 2015-02-10 03:39:57]

LGTM!