Issue 1663 - Made first-run page use an asynchronous messaging protocol

firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
     {
       feature: "tracking",
       homepage: "https://easylist.adblockplus.org/",
       title: "EasyPrivacy",
       url: "https://easylist-downloads.adblockplus.org/easyprivacy.txt"
     }
   ];
 
   function getDocLink(link, callback)
   {
-    ext.backgroundPage.sendMessage({type: "app.doclink", args: [link]}, callback);
+    ext.backgroundPage.sendMessage({
+      type: "app.get",
+      what: "doclink",
+      link: link
+    }, callback);
   }
 
   function onDOMLoaded()
   {
     // Set up URLs
     getDocLink("donate", function(link)
     {
       E("donate").href = link;
     });
 
     getDocLink("contributors", function(link)
     {
       E("contributors").href = link;
     });
 
     getDocLink("acceptable_ads_criteria", function(link)
     {
       setLinks("acceptableAdsExplanation", link, openFilters);
     });
 
     getDocLink("contribute", function(link)
     {
       setLinks("share-headline", link);
     });
 
-    ext.backgroundPage.sendMessage({type: "app.issues"}, function(issues)
+    ext.backgroundPage.sendMessage({
+      type: "app.get",
+      what: "issues"
+    }, function(issues)
     {
       // Show warning if data corruption was detected
       if (issues.seenDataCorruption)
       {
         E("dataCorruptionWarning").removeAttribute("hidden");
         getDocLink("knownIssuesChrome_filterstorage", function(link)
         {
           setLinks("dataCorruptionWarning", link);
         });
       }
 
       // Show warning if filterlists settings were reinitialized
       if (issues.filterlistsReinitialized)
       {
         E("filterlistsReinitializedWarning").removeAttribute("hidden");
         setLinks("filterlistsReinitializedWarning", openFilters);
       }
-    });
-
-    // Show warning if Safari version isn't supported
-    ext.backgroundPage.sendMessage({type: "app.info"}, function(info)
-    {
-      if (info.platform == "safari" && (
-        parseInt(info.platformVersion, 10) < 6 ||  // beforeload breaks websites in Safari 5
-        info.platformVersion == "6.1" ||           // extensions are broken in 6.1 and 7.0
-        info.platformVersion == "7.0"
-      ))
-      {
+
+      if (issues.legacySafariVersion)
         E("legacySafariWarning").removeAttribute("hidden");
-      }
     });
 
     // Set up feature buttons linked to subscriptions
     featureSubscriptions.forEach(initToggleSubscriptionButton);
     updateToggleButtons();
-    initSocialLinks();
+    updateSocialLinks();
 
     ext.onMessage.addListener(function(message)
     {
       if (message.type == "subscriptions.listen")
       {
         updateToggleButtons();
-        initSocialLinks();
-      }
-    });
-    ext.backgroundPage.sendMessage({type: "subscriptions.listen", filter: ["added", "removed", "disabled"]});
+        updateSocialLinks();
+      }
+    });
+    ext.backgroundPage.sendMessage({
+      type: "subscriptions.listen",
+      filter: ["added", "removed", "disabled"]
+    });
   }
 
   function initToggleSubscriptionButton(featureSubscription)
   {
     var feature = featureSubscription.feature;
 
     var element = E("toggle-" + feature);
     element.addEventListener("click", function(event)
     {
       ext.backgroundPage.sendMessage({
@@ skipping 48 matching lines @@
       }
 
       iframe.removeEventListener("load", popupLoadListener);
     };
     iframe.addEventListener("load", popupLoadListener, false);
 
     iframe.src = url;
     glassPane.className = "visible";
   }
 
-  function initSocialLinks()
+  function updateSocialLinks()
   {
     var networks = ["twitter", "facebook", "gplus"];
     networks.forEach(function(network)
     {
       var link = E("share-" + network);
       var message = {
         type: "filters.blocked",
         url: link.getAttribute("data-script"),
         requestType: "SCRIPT",
         docDomain: "adblockplus.org",
@@ skipping 40 matching lines @@
       else if (typeof arguments[i + 1] == "function")
       {
         links[i].href = "javascript:void(0);";
         links[i].addEventListener("click", arguments[i + 1], false);
       }
     }
   }
 
   function openFilters()
   {
-    ext.backgroundPage.sendMessage({type: "app.options"});
+    ext.backgroundPage.sendMessage({type: "app.open", what: "options"});
   }
 
   function updateToggleButtons()
   {
-    ext.backgroundPage.sendMessage({type: "subscriptions.get"}, function(subscriptions)
+    ext.backgroundPage.sendMessage({
+      type: "subscriptions.get",
+      downloadable: true,
+      ignoreDisabled: true
+    }, function(subscriptions)
     {
       for (var i = 0; i < featureSubscriptions.length; i++)
       {
         var featureSubscription = featureSubscriptions[i];
         updateToggleButton(featureSubscription.feature, subscriptions.indexOf(featureSubscription.url) >= 0);
       }
     });
   }
 
   function updateToggleButton(feature, isEnabled)
   {
     var button = E("toggle-" + feature);
     if (isEnabled)
       button.classList.remove("off");
     else
       button.classList.add("off");
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();