Issue 1518 - Got rid of deprecated code using webkitNotifications

background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 399 matching lines @@
         var notification = new Notification(
           title,
           {
             lang: Utils.appLocale,
             dir: ext.i18n.getMessage("@@bidi_dir"),
             body: message,
             icon: iconData
           }
         );
 
-        notification.onclick = openNotificationLinks;
-        notification.onclose = notificationClosed;

[Wladimir Palant, 2015/01/13 07:39:16]

I certainly prefer addEventListener() to onclick - while it is more verbose, you
can just assume that there will be no interactions with other code.

[Sebastian Noack, 2015/01/13 12:30:20]

Thanks for pointing this out. I just overlooked the addEventListener() method
while reading the docs.

+        notification.addEventListener("click", openNotificationLinks);
+        notification.addEventListener("close", notificationClosed);
       });
     }
     else
     {
       var message = title + "\n" + message;
       if (hasLinks)
         message += "\n\n" + ext.i18n.getMessage("notification_with_buttons");
 
       var approved = confirm(message);
       if (activeNotification.type === "question")
@@ skipping 146 matching lines @@
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
 });
 
 setTimeout(function()
 {
   var notificationToShow = NotificationStorage.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);