Don't wrap tab info in Tab if Tab is not defined

chrome/common.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 52 matching lines @@
       target = chrome.extension.onMessage;
     else
       target = chrome.extension.onRequest;
     WrappedEventTarget.call(this, target);
   };
   MessageEventTarget.prototype = {
     __proto__: WrappedEventTarget.prototype,
     _wrapListener: function(listener) {
       return function(message, sender, sendResponse)
       {
-        if (sender.tab && sender.tab.id >= 0)
+        if ("Tab" in window && sender.tab && sender.tab.id >= 0)

[Wladimir Palant, 2014/01/16 08:01:10]

So we have content scripts receive messages where sender.tab is set? That's
weird to say the least. Well, fine with me then...

[Thomas Greiner, 2014/01/16 10:15:30]

Yes, that is the case and it seems like it's intentional:

"The onMessage event is fired in each extension page of the extension."
http://developer.chrome.com/extensions/runtime.html#method-sendMessage

"The tabs.Tab which opened the connection, if any. This property will only be
present when the connection was opened from a tab (including content scripts),
and only if the receiver is an extension, not an app."
http://developer.chrome.com/extensions/runtime.html#type-MessageSender

According to this definition the message (including the tab property) is not
only sent to the background page but also to firstRun.html from the content
script running within the iFrame showing share.adblockplus.org

[Wladimir Palant, 2014/01/16 10:44:49]

Ok, this actually makes sense then.

           sender.tab = new Tab(sender.tab);
         return listener(message, sender, sendResponse);
       };
     }
   };
 
 
   /* API */
 
   ext = {
     backgroundPage: {
       getWindow: function()
       {
         return chrome.extension.getBackgroundPage();
       }
     },
     getURL: chrome.extension.getURL,
     onMessage: new MessageEventTarget(),
     i18n: chrome.i18n
   };
 
   if ("runtime" in chrome && "sendMessage" in chrome.runtime)
     ext.backgroundPage.sendMessage = chrome.runtime.sendMessage;
   else if ("sendMessage" in chrome.extension)
     ext.backgroundPage.sendMessage = chrome.extension.sendMessage;
   else
     ext.backgroundPage.sendMessage = chrome.extension.sendRequest;
 })();