Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/WebRequestJsObject.cpp

Issue 6193234183192576: Issue 1197 - change local copy of v8 (to 4.3.15) to work with Visual Studio 2013 (Closed)
Patch Set: rebase and update Created May 17, 2016, 3:18 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/Utils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/WebRequestJsObject.cpp
diff --git a/src/WebRequestJsObject.cpp b/src/WebRequestJsObject.cpp
index e44e82b55d598135d7c6dd5b5421780bd926193e..46c1bd87657f908be11c6e238df835c8a6527ebc 100644
--- a/src/WebRequestJsObject.cpp
+++ b/src/WebRequestJsObject.cpp
@@ -88,7 +88,7 @@ namespace
AdblockPlus::JsValuePtr callback;
};
- v8::Handle<v8::Value> GETCallback(const v8::Arguments& arguments)
+ void GETCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
{
WebRequestThread* thread;
try
@@ -101,12 +101,9 @@ namespace
}
catch (const std::exception& e)
{
- using AdblockPlus::Utils::ToV8String;
- v8::Isolate* isolate = arguments.GetIsolate();
- return v8::ThrowException(ToV8String(isolate, e.what()));
+ return AdblockPlus::Utils::ThrowException(arguments.GetIsolate(), e.what());
}
thread->Start();
- return v8::Undefined();
}
}
« no previous file with comments | « src/Utils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld