Issue 2298 - Fixed: "Block element" from context menu doesn't reset previous state

include.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 339 matching lines @@
   document.removeEventListener("mouseleave", clickHide_stopPropagation, true);
   document.removeEventListener("mouseover", clickHide_mouseOver, true);
   document.removeEventListener("mouseout", clickHide_mouseOut, true);
   document.removeEventListener("click", clickHide_mouseClick, true);
   document.removeEventListener("keydown", clickHide_keyDown, true);
 }
 
 function clickHide_deactivate()
 {
   clickHide_rulesPending();
-
   clickHide_filters = null;
-  lastRightClickEvent = null;

[Sebastian Noack, 2015/04/10 11:11:17]

In case you wonder, resetting the lastRightClickEvent doesn't really seems to be
necessary. Moreover, now that we call clickHide_activate() which calls
clickHide_deactivate() below, resetting it would result in calling
clickHide_mouseClick(null)

[Sebastian Noack, 2015/04/10 11:32:49]

Never mind. I reverted my decision. Cleaning up makes actually sense. I cache
the event now before calling clickHide_activate().

 
   if (currentElement)
   {
     currentElement.removeEventListener("contextmenu",  clickHide_elementClickHandler, true);
     unhighlightElements();
     unhighlightElement(currentElement);
     currentElement = null;
   }
   unhighlightElements();
 
@@ skipping 319 matching lines @@
         clickHide_activate();
         break;
       case "clickhide-deactivate":
         clickHide_deactivate();
         break;
       case "clickhide-new-filter":
         if(lastRightClickEvent)
         {
           getBlockableElementOrAncestor(lastRightClickEvent.target, function(element)
           {
-            clickHide_activated = true;
+            clickHide_activate();
             currentElement = element;
             clickHide_mouseClick(lastRightClickEvent);
           });
         }
         break;
       case "clickhide-init":
         if (clickHideFiltersDialog)
         {
           sendResponse({filters: clickHide_filters});
 
@@ skipping 37 matching lines @@
           lastRightClickEventValid = false;
         else
           lastRightClickEvent = null;
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "report-html-page"});
 }