Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: html/static/js/ieEventListenerPolyfill.js

Issue 6196733759455232: Issue 1181 - Change polyfill for IE8 (fix settings page) (Closed)
Patch Set: Add back addEventListener/removeEventListener handlers Created Aug. 8, 2014, 1:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « html/static/js/firstRun.js ('k') | html/static/js/ieFirstRun.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 if (typeof window.addEventListener != "function") 1 if (typeof window.addEventListener != "function")
2 { 2 {
3 window.addEventListener = function(type, handler, capture) 3 window.addEventListener = function(type, handler, capture)
4 { 4 {
5 this.attachEvent("on" + type, handler) 5 this.attachEvent("on" + type, handler)
6 }; 6 };
7 } 7 }
8 8
9 if (typeof window.removeEventListener != "function") 9 if (typeof window.removeEventListener != "function")
10 { 10 {
11 window.removeEventListener = function(type, handler) 11 window.removeEventListener = function(type, handler)
12 { 12 {
13 this.detachEvent("on" + type, handler) 13 this.detachEvent("on" + type, handler)
14 }; 14 };
15 } 15 }
16
17 if (typeof Element.prototype.addEventListener != "function")
Felix Dahlke 2014/08/08 13:58:35 My question remains: Is this still necessary to fi
Oleksandr 2014/08/08 14:05:17 Oh, I miss understood you before then. Yes, it is
Felix Dahlke 2014/08/08 14:07:01 Ah, I see! Misunderstanding then.
18 {
19 Element.prototype.addEventListener = function(type, handler, capture)
Felix Dahlke 2014/08/08 14:07:01 Can we assign this to window.addEventListener, and
20 {
21 this.attachEvent("on" + type, handler)
22 };
23 }
24
25 if (typeof Element.prototype.removeEventListener != "function")
26 {
27 Element.prototype.removeEventListener = function(type, handler)
28 {
29 this.detachEvent("on" + type, handler)
30 };
31 }
OLDNEW
« no previous file with comments | « html/static/js/firstRun.js ('k') | html/static/js/ieFirstRun.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld