Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: html/static/js/ieEventListenerPolyfill.js

Issue 6196733759455232: Issue 1181 - Change polyfill for IE8 (fix settings page) (Closed)
Patch Set: Reuse code for addEventListener/removeEventListener Created Aug. 8, 2014, 2:18 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « html/static/js/firstRun.js ('k') | html/static/js/ieFirstRun.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 if (typeof window.addEventListener != "function") 1 if (typeof window.addEventListener != "function")
2 { 2 {
3 window.addEventListener = function(type, handler, capture) 3 window.addEventListener = function(type, handler, capture)
4 { 4 {
5 this.attachEvent("on" + type, handler) 5 this.attachEvent("on" + type, handler)
6 }; 6 };
7 } 7 }
8 8
9 if (typeof window.removeEventListener != "function") 9 if (typeof window.removeEventListener != "function")
10 { 10 {
11 window.removeEventListener = function(type, handler) 11 window.removeEventListener = function(type, handler)
12 { 12 {
13 this.detachEvent("on" + type, handler) 13 this.detachEvent("on" + type, handler)
14 }; 14 };
15 } 15 }
16
17 if (typeof Element.prototype.addEventListener != "function")
18 {
19 Element.prototype.addEventListener = window.addEventListener;
Oleksandr 2014/08/08 14:19:34 Looks like we've tried every combination now :)
Felix Dahlke 2014/08/08 14:21:12 Yes, I like this one best :)
20 }
21
22 if (typeof Element.prototype.removeEventListener != "function")
23 {
24 Element.prototype.removeEventListener = window.removeEventListener;
25 }
OLDNEW
« no previous file with comments | « html/static/js/firstRun.js ('k') | html/static/js/ieFirstRun.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld