Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 6201308310667264: Issue 521- Inject our stylesheet on per-site basis rather than globally (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by tschuster
Modified:
3 years, 4 months ago
Reviewers:
Wladimir Palant
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 521- Inject our stylesheet on per-site basis rather than globally

Patch Set 1 #

Total comments: 7

Patch Set 2 : WIP #

Total comments: 3

Patch Set 3 : New patch set that is a lot simpler and retains compatibility with old Firefox versions where the F… #

Patch Set 4 : Wladimir what do you think? I think I have seen the case happen once where we observe 'content-docu… #

Patch Set 5 : Version 1.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -62 lines) Patch
M lib/contentPolicy.js View 1 2 3 1 chunk +68 lines, -49 lines 0 comments Download
M lib/elemHide.js View 1 2 3 4 6 chunks +62 lines, -13 lines 0 comments Download

Messages

Total messages: 9
Wladimir Palant
http://codereview.adblockplus.org/6201308310667264/diff/5629499534213120/lib/elemHide.js File lib/elemHide.js (right): http://codereview.adblockplus.org/6201308310667264/diff/5629499534213120/lib/elemHide.js#newcode86 lib/elemHide.js:86: }); This code is no longer necessary. http://codereview.adblockplus.org/6201308310667264/diff/5629499534213120/lib/elemHide.js#newcode140 lib/elemHide.js:140: ...
5 years, 5 months ago (2014-05-20 19:36:12 UTC) #1
tschuster
This is not totally ready yet, but I thought it would be a good idea ...
5 years, 4 months ago (2014-06-04 17:55:08 UTC) #2
tschuster
http://codereview.adblockplus.org/6201308310667264/diff/5649050225344512/lib/contentPolicy.js File lib/contentPolicy.js (right): http://codereview.adblockplus.org/6201308310667264/diff/5649050225344512/lib/contentPolicy.js#newcode167 lib/contentPolicy.js:167: if (!(match instanceof WhitelistFilter)) I think we should make ...
5 years, 4 months ago (2014-06-04 18:07:40 UTC) #3
tschuster
Hey Wladimir, I would appreciate if you could answer some question, sadly we seem to ...
5 years, 4 months ago (2014-06-05 19:00:34 UTC) #4
tschuster
New patch set that is a lot simpler and retains compatibility with old Firefox versions ...
5 years, 3 months ago (2014-06-28 10:38:35 UTC) #5
tschuster
Wladimir what do you think? I think I have seen the case happen once where ...
5 years, 3 months ago (2014-07-18 15:47:43 UTC) #6
tschuster
Wladimir please review.
5 years, 2 months ago (2014-08-06 16:30:18 UTC) #7
tschuster
On 2014/08/06 16:30:18, tschuster wrote: > Wladimir please review. This could reduce memory quite a ...
4 years, 12 months ago (2014-10-19 21:51:14 UTC) #8
tschuster
4 years, 2 months ago (2015-07-21 10:37:16 UTC) #9
On 2014/10/19 21:51:14, tschuster wrote:
> On 2014/08/06 16:30:18, tschuster wrote:
> > Wladimir please review.
> 
> This could reduce memory quite a bit, I would appreciate if you could take a
> look.

I don't think so. -> Closing
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5