Disable add-on compatibility checking

Disable add-on compatibility checking

We're embedding Adblock Plus, which requires fennec 25.0. Adblock
Browser, however, is at version 1.0.0. Once it has its own app ID, we
can declare compatibility in Adblock Plus properly. But we can't do
that while Adblock Browser hasn't been announced yet, so we're
disabling compatibility checking for now.

[Felix Dahlke, 2015-03-01 07:01:51]

Would be brilliant if you can have a look soon - with this I can announce a
working build.

http://codereview.adblockplus.org/6203978345873408/diff/5629499534213120/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/6203978345873408/diff/5629499534213120/mobi...
mobile/android/app/mobile.js:193: pref("extensions.checkCompatibility.nightly",
false);
MOZ_COMPATIBILITY_NIGHTLY is set, because MOZ_UPDATE_CHANNEL is not set to
either of "aurora", "beta", "release" or "esr". Don't want to make a too
intrusive change here, so I think it's best to keep it at that. Also, it means
we don't have to keep the version here in sync with the app version.

[René Jeschke, 2015-03-01 14:59:06]

LGTM

[Wladimir Palant, 2015-03-01 18:02:24]

LGTM if this is meant as a temporary hack - it needs to be fixed properly before
release.

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
mobile/android/app/mobile.js:199: pref("extensions.checkCompatibility.nightly",
false);
We have a toolkit compatibility entry, any idea why it isn't working? Probably
because we have an explicit entry matching the current app? Then maybe removing
the Fennec entry from the Adblock Plus build would be sufficient.

Note that this pref won't work for a release build.

[Felix Dahlke, 2015-03-02 06:22:32]

Yes, certainly a temporary thing, see below.

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
mobile/android/app/mobile.js:199: pref("extensions.checkCompatibility.nightly",
false);
On 2015/03/01 18:02:24, Wladimir Palant wrote:
> We have a toolkit compatibility entry, any idea why it isn't working? Probably
> because we have an explicit entry matching the current app? Then maybe
removing
> the Fennec entry from the Adblock Plus build would be sufficient.

Well, giving the browser a different app ID and adjusting
extensions.minCompatibleAppVersion does make ABP pass the compatibility check.

However, as discussed in the card
(https://trello.com/c/kGF3T6rx/54-change-the-app-id), ABP doesn't actually work
if we change the app ID, I'm afraid we'd have to make changes we don't want to
make right now.