Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 6203978345873408: Disable add-on compatibility checking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 6 months ago
Visibility:
Public.

Description

Disable add-on compatibility checking We're embedding Adblock Plus, which requires fennec 25.0. Adblock Browser, however, is at version 1.0.0. Once it has its own app ID, we can declare compatibility in Adblock Plus properly. But we can't do that while Adblock Browser hasn't been announced yet, so we're disabling compatibility checking for now.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M mobile/android/app/mobile.js View 1 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 4
Felix Dahlke
Would be brilliant if you can have a look soon - with this I can ...
4 years, 9 months ago (2015-03-01 07:01:51 UTC) #1
René Jeschke
LGTM
4 years, 9 months ago (2015-03-01 14:59:06 UTC) #2
Wladimir Palant
LGTM if this is meant as a temporary hack - it needs to be fixed ...
4 years, 9 months ago (2015-03-01 18:02:24 UTC) #3
Felix Dahlke
4 years, 9 months ago (2015-03-02 06:22:32 UTC) #4
Yes, certainly a temporary thing, see below.

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
File mobile/android/app/mobile.js (right):

http://codereview.adblockplus.org/6203978345873408/diff/5741031244955648/mobi...
mobile/android/app/mobile.js:199: pref("extensions.checkCompatibility.nightly",
false);
On 2015/03/01 18:02:24, Wladimir Palant wrote:
> We have a toolkit compatibility entry, any idea why it isn't working? Probably
> because we have an explicit entry matching the current app? Then maybe
removing
> the Fennec entry from the Adblock Plus build would be sufficient.

Well, giving the browser a different app ID and adjusting
extensions.minCompatibleAppVersion does make ABP pass the compatibility check.

However, as discussed in the card
(https://trello.com/c/kGF3T6rx/54-change-the-app-id), ABP doesn't actually work
if we change the app ID, I'm afraid we'd have to make changes we don't want to
make right now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5