Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6203978345873408: Disable add-on compatibility checking (Closed)

March 1, 2015, 6:53 a.m. by Felix Dahlke
May 21, 2015, 11:57 a.m.


Disable add-on compatibility checking We're embedding Adblock Plus, which requires fennec 25.0. Adblock Browser, however, is at version 1.0.0. Once it has its own app ID, we can declare compatibility in Adblock Plus properly. But we can't do that while Adblock Browser hasn't been announced yet, so we're disabling compatibility checking for now.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M mobile/android/app/mobile.js View 1 1 chunk +7 lines, -0 lines 2 comments Download


Total messages: 4
Felix Dahlke
Would be brilliant if you can have a look soon - with this I can ...
March 1, 2015, 7:01 a.m. (2015-03-01 07:01:51 UTC) #1
René Jeschke
March 1, 2015, 2:59 p.m. (2015-03-01 14:59:06 UTC) #2
Wladimir Palant
LGTM if this is meant as a temporary hack - it needs to be fixed ...
March 1, 2015, 6:02 p.m. (2015-03-01 18:02:24 UTC) #3
Felix Dahlke
March 2, 2015, 6:22 a.m. (2015-03-02 06:22:32 UTC) #4
Yes, certainly a temporary thing, see below.

File mobile/android/app/mobile.js (right):

mobile/android/app/mobile.js:199: pref("extensions.checkCompatibility.nightly",
On 2015/03/01 18:02:24, Wladimir Palant wrote:
> We have a toolkit compatibility entry, any idea why it isn't working? Probably
> because we have an explicit entry matching the current app? Then maybe
> the Fennec entry from the Adblock Plus build would be sufficient.

Well, giving the browser a different app ID and adjusting
extensions.minCompatibleAppVersion does make ABP pass the compatibility check.

However, as discussed in the card
(https://trello.com/c/kGF3T6rx/54-change-the-app-id), ABP doesn't actually work
if we change the app ID, I'm afraid we'd have to make changes we don't want to
make right now.

Powered by Google App Engine
This is Rietveld