Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClass.cpp

Issue 6210609305616384: Issue 1538 - Replace ABP icon with new one (v.1.1) - for Internet Explorer (Closed)
Patch Set: Correct rebase Created March 30, 2015, 11:12 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « installer/src/setup-exe/abp-64.png ('k') | src/res/blocking.ico » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -44,6 +44,8 @@
HICON CPluginClass::s_hIcons[ICON_MAX] = { NULL, NULL, NULL };
DWORD CPluginClass::s_hIconTypes[ICON_MAX] = { IDI_ICON_DISABLED, IDI_ICON_ENABLED, IDI_ICON_DEACTIVATED };
+uint32_t iconHeight = 32;
+uint32_t iconWidth = 32;
CPluginMimeFilterClient* CPluginClass::s_mimeFilter = NULL;
@@ -992,10 +994,16 @@
if (rcStatusBar.Height() > 0)
{
+ if (rcStatusBar.Height() < iconWidth)
+ {
+ iconWidth = 19;
+ iconHeight = 19;
+ }
+
#ifdef _DEBUG
m_nPaneWidth = 70;
#else
- m_nPaneWidth = min(rcStatusBar.Height(), 22);
+ m_nPaneWidth = min(rcStatusBar.Height(), iconWidth);
#endif
}
else
@@ -1003,7 +1011,7 @@
#ifdef _DEBUG
m_nPaneWidth = 70;
#else
- m_nPaneWidth = 22;
+ m_nPaneWidth = iconWidth;
#endif
}
// Create pane window
@@ -1012,7 +1020,7 @@
MAKEINTATOM(GetAtomPaneClass()),
L"",
WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | WS_CLIPCHILDREN,
- rcStatusBar.Width() - 500,0,m_nPaneWidth,rcStatusBar.Height(),
+ rcStatusBar.Width() - 500, 0, m_nPaneWidth, rcStatusBar.Height(),
hWndStatusBar,
(HMENU)3671,
_Module.m_hInst,
@@ -1621,8 +1629,11 @@
int offx = nDrawEdge;
if (hIcon)
{
- ::DrawIconEx(hDC, offx, (rcClient.Height() - 16)/2 + 2, hIcon, 16, 16, NULL, NULL, DI_NORMAL);
- offx += 22;
+ //Get the RECT for the leftmost pane (the status text pane)
+ RECT rect;
+ BOOL rectRes = ::SendMessage(pClass->m_hStatusBarWnd, SB_GETRECT, 0, (LPARAM)&rect);
+ ::DrawIconEx(hDC, 0, rect.bottom - rect.top - iconHeight, hIcon, iconWidth, iconHeight, NULL, NULL, DI_NORMAL);
+ offx += iconWidth;
}
#ifdef _DEBUG
// Display version
@@ -1790,7 +1801,9 @@
{
if (!s_hIcons[type])
{
- s_hIcons[type] = ::LoadIcon(_Module.m_hInst, MAKEINTRESOURCE(s_hIconTypes[type]));
+ std::wstring imageToLoad = L"#";
+ imageToLoad += std::to_wstring(s_hIconTypes[type]);
+ s_hIcons[type] = (HICON)::LoadImage(_Module.m_hInst, imageToLoad.c_str(), IMAGE_ICON, iconWidth, iconHeight, LR_SHARED);
if (!s_hIcons[type])
{
DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_UI, PLUGIN_ERROR_UI_LOAD_ICON, "Class::GetIcon - LoadIcon")
« no previous file with comments | « installer/src/setup-exe/abp-64.png ('k') | src/res/blocking.ico » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld