Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 6215705351421952: Issue 2254 - Ignore stderr when jsdoc completes successfull (Closed)
Patch Set: Created April 1, 2015, 10:59 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -374,7 +374,12 @@
'--access', 'all',
os.path.join(baseDir, 'lib')]
if any(opt in ('-q', '--quiet') for opt, _ in opts):
- subprocess.check_output(command)
+ process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ stderr = process.communicate()[1]
+ retcode = process.poll()
+ if retcode:
+ sys.stderr.write(stderr)
+ raise subprocess.CalledProcessError(command, retcode)
else:
subprocess.check_call(command)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld