Issue #404 - Create common library shared between plugin/engine and installer

common/include/IeVersion.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef IE_VERSION_H
 #define IE_VERSION_H
 
 #include <string>
 
 namespace AdblockPlus
 {
   namespace IE

[Oleksandr, 2015/03/04 05:26:29]

Do we actually need these namespaces here? We don't generally have them in IE
code anyway. Can't we just drop these? Looks kind of C#-y this way, IMO.

[sergei, 2015/03/04 08:02:00]

If we drop them then we need to rename the methods. I guess, `namespace IE` here
is equivalent of `class IE`, I personally like it more than static methods of
the class.

[Eric, 2015/03/04 14:15:16]

First, I'd like to observe that the original purpose for this change set was to
alter the build. I split up one of the test files to conform to the split-file
pattern we're moving to and cleaned up some old names in the process. Renaming
things that aren't part of the build, though, is getting out of scope for the
present change set.
It looks like the pattern we're using in libadblockplus.

[Eric, 2015/03/04 14:15:16]

That's exactly why I used a namespace here in the first place. It's bad form to
use public static functions in a class when those function do not touch any
static data for this class. We have a whole lot of such functions in the code
already that ought to be converted to free-standing functions, whether in a
namespace or not. (Example: 'UnescapeUrl' used to be public static function.)

I used a namespace here because these version functions were always intended to
be used in more than just the plugin or engine.

[Oleksandr, 2015/03/04 15:37:23]

Why does it have to be a namespace or a class? Can't these 2 function be just
free floating as we have them in Utils.h or in PluginUtil.h?

We shouldn't be aiming at having the same namespace in libadblockplus and in IE.
IE code is different, so here it would have to be something like AdblockPlusIe.

I understand the namespaces weren't introduced in the patchset though, so yes,
it's a good idea to do it in a separate commit.

[Eric, 2015/03/04 16:55:10]

Yes. Good.

   {
     std::wstring InstalledVersionString();
     int InstalledMajorVersion();
   }
 }
 
 #endif