Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: common/common.gypi

Issue 6216090891845632: Issue #404 - Create common library shared between plugin/engine and installer (Closed)
Left Patch Set: Rename to IeVersion*.*; fix URL in copyright notice Created Feb. 27, 2015, 1:50 p.m.
Right Patch Set: final check after rebase Created May 19, 2015, 3:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « adblockplus.gyp ('k') | common/include/IeVersion.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of Adblock Plus <https://adblockplus.org/>, 1 # This file is part of Adblock Plus <https://adblockplus.org/>,
2 # Copyright (C) 2006-2015 Eyeo GmbH 2 # Copyright (C) 2006-2015 Eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 'sources': [ 43 'sources': [
44 'test/RegistryTest.cpp', 44 'test/RegistryTest.cpp',
45 'test/IeVersionTest.cpp', 45 'test/IeVersionTest.cpp',
46 ], 46 ],
47 'defines': ['WINVER=0x0501'], 47 'defines': ['WINVER=0x0501'],
48 'link_settings': { 48 'link_settings': {
49 'libraries': ['-ladvapi32', '-lshell32', '-lole32'], 49 'libraries': ['-ladvapi32', '-lshell32', '-lole32'],
50 }, 50 },
51 'msvs_settings': { 51 'msvs_settings': {
52 'VCLinkerTool': { 52 'VCLinkerTool': {
53 'SubSystem': '1', # Console 53 'SubSystem': '1', # Console
Oleksandr 2015/03/04 05:26:29 Nit: No space after #
sergei 2015/03/04 08:02:00 Did you mean "one space before #"? Actually, as I
Eric 2015/03/04 14:15:16 This 'msvs_settings' section is copypasta from the
Oleksandr 2015/03/04 15:37:23 Yes, I actually was meant to say one space _before
Eric 2015/03/04 16:55:10 I fixed all of them. We're already altering adbloc
54 'EntryPointSymbol': 'mainCRTStartup', 54 'EntryPointSymbol': 'mainCRTStartup',
55 }, 55 },
56 }, 56 },
57 }, 57 },
58 ] 58 ]
59 } 59 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld