Issue #404 - Create common library shared between plugin/engine and installer

common/test/IeVersionTest.cpp

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <gtest/gtest.h>
 #include "IE_Version.h"
 
 /*
  * Exact version tests enabled by default.
- * If they are disabled, gtext will report 2 disabled tests.

[sergei, 2015/03/04 15:53:56]

Just to note, gtest, not gtext.

[Eric, 2015/03/04 16:55:10]

Done.

+ * If they are disabled, gtest will report 2 disabled tests.
  */
 #if !defined(DISABLE_EXACT_TESTS)

[Oleksandr, 2015/03/04 15:37:23]

How about just using if !defined(INSTALLED_IE_VERSION) instead? Otherwise on
some systems we might have a test that will always fail. And there would be less
redundancy, IMO.

[Eric, 2015/03/04 16:55:10]

If we change it, we can change it elsewhere and later.

For the record, though, there are two definitions because they have two
different purposes.

1) INSTALLED_IE_VERSION enables the main repository can track whatever the
current release of IE is. This is independent of whether the current development
configuration is using it or not.

2) DISABLE_EXACT_TESTS is for quick suppression for testing with previous
versions, presumably in a VM, and temporarily so by mashing over the default
command line definitions in the project file generated by GYP. If you don't want
to suppress the test for whatever reason, define INSTALLED_IE_VERSION instead.

The only reason the test might _always_ fail is if there's no IE installed or
the current IE isn't installed. The first case is irrelevant and the second case
has not been problematic.

[Felix Dahlke, 2015/03/05 13:33:06]

The code is being introduced here - if we want to change it let's do it now. We
have enough questionable code we hope to change some day in IE as it is.
the current IE isn't installed.

Not everyone is on IE11, stuff shouldn't fail by default on common systems. And
if we don't run the tests by default, DISABLE_EXACT_TESTS is entirely redundant
indeed.

[Eric, 2015/03/05 14:49:48]

It is not being introduced here. It's being moved from one directory to another.
Mercurial records that as a deletion and a new file, so it looks in the review
tool like brand new code.

 #define exact(x) Exact##x
 #else
 #define exact(x) DISABLED_Exact##x
 #endif
 /*
  * Define a default version as the current version of IE in general release.
  * Predefine on the command line to compile tests for non-standard development environments.
  */
 #ifndef INSTALLED_IE_VERSION
 #define INSTALLED_IE_VERSION 11
@@ skipping 20 matching lines @@
     std::wstring version = AdblockPlus::IE::InstalledVersionString();
     std::wstring expected = std::to_wstring(INSTALLED_IE_VERSION) + L".";
     ASSERT_EQ(expected, version.substr(0, expected.length()));
 }
 
 TEST(InstalledMajorVersionTest, exact(MajorOnly))
 {
   int version = AdblockPlus::IE::InstalledMajorVersion();
   ASSERT_EQ(version, INSTALLED_IE_VERSION);
 }