Issue #276 - conversion functions between std::wstring and ATL::CString

src/plugin/ATL_Deprecate.cpp

Index: src/plugin/ATL_Deprecate.cpp
===================================================================
new file mode 100644
--- /dev/null
+++ b/src/plugin/ATL_Deprecate.cpp
@@ -0,0 +1,16 @@
+/**
+ * \file ATL_Deprecate.cpp Transient functions used during the ATL removal process.
+ */
+
+#include "ATL_Deprecate.h"
+
+std::wstring to_wstring(const ATL::CString& s)

[Felix Dahlke, 2014/09/30 13:21:36]

Am I missing something, or why do we use underscore naming here? Should be
ToWstring here and ToCString below.

[Eric, 2014/09/30 15:43:34]

This code was originally written months ago, before we addressed the issues
around differences in style.

These functions are scheduled to disappear entirely once we've converted all the
remaining CString occurrences to std::wstring. When that happens, both of these
function definitions and their corresponding declarations will go away entirely.

While we could change these names at this point, it would be a bunch of work for
not much benefit. We'd need to change the names for all declaration, definition,
and usages, get that committed. That would delay the work on the conversion by
putting such a revision onto the critical path of resolving the issue.

Given the explicit transience of these functions, I'd recommend living with the
legacy nature of these names.

+{
+  std::wstring result(static_cast<const wchar_t *>(s));

[Felix Dahlke, 2014/09/30 13:21:36]

No space between wchar_t and * please.

+  return result;
+}
+
+ATL::CString to_CString(const std::wstring& s)
+{
+  return ATL::CString(s.c_str());
+}