Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 6227976249147392: Fix whitelisting issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by Felix Dahlke
Modified:
5 years, 9 months ago
Reviewers:
Wladimir Palant
CC:
Andrey Novikov
Visibility:
Public.

Description

This patch fixes various whitelisting issues, there were three problems in particular: 1. Frame requests got the document type "OTHER" instead of "SUBDOCUMENT" 2. We didn't record the full URL in referrer mappings 3. The referrer chain was built the wrong way around

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/org/adblockplus/android/AdblockPlus.java View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
I will push this in a few minutes since noone is around to review it.
5 years, 9 months ago (2013-11-29 15:36:03 UTC) #1
Felix Dahlke
Pushed: https://hg.adblockplus.org/adblockplusandroid/rev/5bea5418cd3a
5 years, 9 months ago (2013-11-29 15:46:26 UTC) #2
Wladimir Palant
5 years, 9 months ago (2013-12-02 09:29:08 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5