Issue 2064 - Configure indistinguishable request types in the abstraction layer

safari/ext/content.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 60 matching lines @@
     {
       case "frame":
       case "iframe":
         type = "SUBDOCUMENT";
         eventName = "load";
         break;
       case "img":
       case "input":
         type = "IMAGE";
         break;
+      case "video":
+      case "audio":
+      case "source":
+        type = "MEDIA";

[kzar, 2015/03/02 16:56:53]

One thought I had was that you could add most of these as indistinguishable type
arrays and therefore simplify this logic. Not sure if it's a good idea though.

[Sebastian Noack, 2015/03/02 16:59:26]

All types handled here are actually distinguishable. So this doesn't make any
sense to me. And regardless of the indistinguishable types, I need to map the
types that are actually distinguishable.

[kzar, 2015/03/02 17:04:29]

So for example I thought you could add ["MEDIA", "video", "audio", "source"] to
the indistinguishable types array and therefore not need the logic here that you
added, you would just need to set type to event.target.localName and have a bit
of logic for the special cases like "iframe" where something else happens too.

Again I'm not sure that it's actually a good idea, just a thought.

[Sebastian Noack, 2015/03/02 17:08:49]

This won't work, since "video", "audio" and "source" aren't valid types, but
merely tag names.

+        break;
       case "object":
       case "embed":
         type = "OBJECT";
         break;
       case "script":
         type = "SCRIPT";
         break;
       case "link":
         if (/\bstylesheet\b/i.test(event.target.rel))
           type = "STYLESHEET";
@@ skipping 337 matching lines @@
   });
 
 
   /* Detecting extension reload/disable/uninstall (not supported on Safari) */
 
   ext.onExtensionUnloaded = {
     addListener: function() {},
     removeListener: function() {}
   };
 })();