Issue 1713 - (Disable/Enable on ...) not showing on FF Mobile

lib/appSupport.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 684 matching lines @@
 
     exports.getBrowser = (window) => window.BrowserApp.selectedBrowser;
 
     exports.addTab = (window, url, event) => window.BrowserApp.addTab(url, {selected: true});
 
     let BrowserChangeListener = function(window, callback)
     {
       this.window = window;
       this.callback = callback;
       this.onSelect = this.onSelect.bind(this);
+      this.attach = this.attach.bind(this);
       if (window.BrowserApp.deck)
         this.attach();
       else
-        window.addEventListener("UIReady", this.attach.bind(this), false);

[Wladimir Palant, 2014/12/28 11:28:23]

This listener needs to be removed when it fires, otherwise we'll be leaking
memory here (until the window is closed).

[saroyanm, 2014/12/28 19:30:14]

Done.

+        window.addEventListener("UIReady", this.attach, false);
     };
     BrowserChangeListener.prototype = {
       window: null,
       callback: null,
       currentBrowser: null,
 
       setBrowser: function(browser)
       {
         if (browser != this.currentBrowser)
         {
           let oldBrowser = this.currentBrowser;
           this.currentBrowser = browser;
           this.callback(oldBrowser, browser);
         }
       },
 
       onSelect: function()
       {
         let {Utils} = require("utils");
         Utils.runAsync(function()
         {
           this.setBrowser(exports.getBrowser(this.window));
         }.bind(this));
       },
 
       attach: function()
       {
+        this.window.removeEventListener("UIReady", this.attach, false);
         this.onSelect();
-
         this.window.BrowserApp.deck.addEventListener("TabSelect", this.onSelect, false);
       },
       detach: function()
       {
         this.window.BrowserApp.deck.removeEventListener("TabSelect", this.onSelect, false);
 
         this.setBrowser(null);
       }
     };
 
@@ skipping 202 matching lines @@
             event.state = {id: require("info").addonID};
             browser._contentWindow.dispatchEvent(event);
           });
         });
       }, true);
     };
 
     break;
   }
 }