Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/UpdateCheck.cpp

Issue 6233220328718336: Issue #3593, #1197- fix isolate management (Closed)
Left Patch Set: fix the crash (hacky) Created Nov. 16, 2015, 4:51 p.m.
Right Patch Set: rebase fix v8 initialization Created May 20, 2016, 3:22 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/Prefs.cpp ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 webRequest = new TestWebRequest(); 63 webRequest = new TestWebRequest();
64 webRequestPtr.reset(webRequest); 64 webRequestPtr.reset(webRequest);
65 65
66 eventCallbackCalled = false; 66 eventCallbackCalled = false;
67 updateCallbackCalled = false; 67 updateCallbackCalled = false;
68 Reset(); 68 Reset();
69 } 69 }
70 70
71 void Reset() 71 void Reset()
72 { 72 {
73 jsEngine = createJsEngine(appInfo); 73 jsEngine = CreateJsEngine(appInfo);
74 jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new LazyLogSystem)); 74 jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new LazyLogSystem));
75 jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new LazyFileSystem)); 75 jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new LazyFileSystem));
76 jsEngine->SetWebRequest(webRequestPtr); 76 jsEngine->SetWebRequest(webRequestPtr);
77 jsEngine->SetEventCallback("updateAvailable", 77 jsEngine->SetEventCallback("updateAvailable",
78 std::bind(&UpdateCheckTest::EventCallback, this, std::placeholders::_1 )); 78 std::bind(&UpdateCheckTest::EventCallback, this, std::placeholders::_1 ));
79 79
80 filterEngine.reset(new AdblockPlus::FilterEngine(jsEngine)); 80 filterEngine.reset(new AdblockPlus::FilterEngine(jsEngine));
81 } 81 }
82 82
83 void ForceUpdateCheck() 83 void ForceUpdateCheck()
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 256
257 Reset(); 257 Reset();
258 ForceUpdateCheck(); 258 ForceUpdateCheck();
259 259
260 AdblockPlus::Sleep(100); 260 AdblockPlus::Sleep(100);
261 261
262 ASSERT_FALSE(eventCallbackCalled); 262 ASSERT_FALSE(eventCallbackCalled);
263 ASSERT_TRUE(updateCallbackCalled); 263 ASSERT_TRUE(updateCallbackCalled);
264 ASSERT_FALSE(updateError.empty()); 264 ASSERT_FALSE(updateError.empty());
265 } 265 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld