Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/BaseJsTest.h

Issue 6233220328718336: Issue #3593, #1197- fix isolate management (Closed)
Left Patch Set: make ScopedV8Isolate uncopyable Created Jan. 22, 2016, 10:39 a.m.
Right Patch Set: rebase fix v8 initialization Created May 20, 2016, 3:22 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/JsValue.cpp ('k') | test/BaseJsTest.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 class LazyLogSystem : public AdblockPlus::LogSystem 132 class LazyLogSystem : public AdblockPlus::LogSystem
133 { 133 {
134 public: 134 public:
135 void operator()(LogLevel logLevel, const std::string& message, 135 void operator()(LogLevel logLevel, const std::string& message,
136 const std::string& source) 136 const std::string& source)
137 { 137 {
138 } 138 }
139 }; 139 };
140 140
141 AdblockPlus::JsEnginePtr createJsEngine(const AdblockPlus::AppInfo& appInfo = Ad blockPlus::AppInfo()); 141 AdblockPlus::JsEnginePtr CreateJsEngine(const AdblockPlus::AppInfo& appInfo = Ad blockPlus::AppInfo());
Eric 2016/01/26 14:48:59 In a suggestion that also appears elsewhere in a d
Eric 2016/01/26 14:48:59 According to our style guide, this should be "Crea
sergei 2016/01/27 15:06:10 How can it be omitted? In some tests we need it in
sergei 2016/01/27 15:06:11 Done.
Eric 2016/01/27 17:21:02 OK. I'm not familiar with the unit test suite for
142 142
143 class BaseJsTest : public ::testing::Test 143 class BaseJsTest : public ::testing::Test
144 { 144 {
145 protected: 145 protected:
146 AdblockPlus::JsEnginePtr jsEngine; 146 AdblockPlus::JsEnginePtr jsEngine;
147 147
148 virtual void SetUp() 148 virtual void SetUp()
149 { 149 {
150 jsEngine = createJsEngine(); 150 jsEngine = CreateJsEngine();
151 jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new ThrowingLogSystem)); 151 jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new ThrowingLogSystem));
152 jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new ThrowingFileSystem)); 152 jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new ThrowingFileSystem));
153 jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new ThrowingWebRequest)); 153 jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new ThrowingWebRequest));
154 } 154 }
155 }; 155 };
156 156
157
158 #endif 157 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld