Issue #3593, #1197- fix isolate management

test/BaseJsTest.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 120 matching lines @@
 
 class LazyLogSystem : public AdblockPlus::LogSystem
 {
 public:
   void operator()(LogLevel logLevel, const std::string& message,
           const std::string& source)
   {
   }
 };
 
-AdblockPlus::JsEnginePtr createJsEngine(const AdblockPlus::AppInfo& appInfo = AdblockPlus::AppInfo());

[Eric, 2016/01/26 14:48:59]

In a suggestion that also appears elsewhere in a different way, the 'appInfo'
argument could be omitted in favor of using application info that identifies the
application as "unit tests".

[Eric, 2016/01/26 14:48:59]

According to our style guide, this should be "CreateJsEngine".

[sergei, 2016/01/27 15:06:10]

How can it be omitted? In some tests we need it in some the default constructed
AppInfo is used and there is no reason to create the second method that calls
JsEngine::New with default AppInfo.

[sergei, 2016/01/27 15:06:11]

Done.

[Eric, 2016/01/27 17:21:02]

OK. I'm not familiar with the unit test suite for this module. It does surprise
me, however, that any tests rely on default 'AppInfo'.

+AdblockPlus::JsEnginePtr CreateJsEngine(const AdblockPlus::AppInfo& appInfo = AdblockPlus::AppInfo());
 
 class BaseJsTest : public ::testing::Test
 {
 protected:
   AdblockPlus::JsEnginePtr jsEngine;
 
   virtual void SetUp()
   {
-    jsEngine = createJsEngine();
+    jsEngine = CreateJsEngine();
     jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new ThrowingLogSystem));
     jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new ThrowingFileSystem));
     jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new ThrowingWebRequest));
   }
 };
 
-
 #endif