Issue #3593, #1197- fix isolate management

test/BaseJsTest.cpp

Index: test/BaseJsTest.cpp
diff --git a/test/BaseJsTest.cpp b/test/BaseJsTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..8c0d22029b26fedc0133e308b5ec9a7a5040ead4
--- /dev/null
+++ b/test/BaseJsTest.cpp
@@ -0,0 +1,24 @@
+/*
+* This file is part of Adblock Plus <https://adblockplus.org/>,
+* Copyright (C) 2006-2015 Eyeo GmbH
+*
+* Adblock Plus is free software: you can redistribute it and/or modify
+* it under the terms of the GNU General Public License version 3 as
+* published by the Free Software Foundation.
+*
+* Adblock Plus is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU General Public License for more details.
+*
+* You should have received a copy of the GNU General Public License
+* along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include "BaseJsTest.h"
+
+AdblockPlus::JsEnginePtr CreateJsEngine(const AdblockPlus::AppInfo& appInfo)
+{
+  static AdblockPlus::ScopedV8IsolatePtr isolate = std::make_shared<AdblockPlus::ScopedV8Isolate>();
+  return AdblockPlus::JsEngine::New(appInfo, isolate);

[Eric, 2016/01/27 17:21:03]

As has been discussed elsewhere, I'd create a single static 'JsEngine' and share
that. It would promote better encapsulation in the 'JsEngine' constructor,
eliminating the isolate argument.

[sergei, 2016/01/28 14:02:51]

We cannot share JsEngine because it is specifically initialized in most tests
and we don't need an instance of JsEngine partially initialized in one test to
be used in another one. For example, we set MockFileSystem as a "file system
engine" and we don't want to be affected by that particular implementation and
by its state in other tests.

[Eric, 2016/01/28 16:42:41]

Acknowledged.

+}