Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 6235761431019520: Issue 342 - Speed up options page with many user filters on Safari (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by Sebastian Noack
Modified:
5 years, 10 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 342 - Speed up options page with many user filters on Safari

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -26 lines) Patch
M background.js View 2 chunks +28 lines, -0 lines 1 comment Download
M options.js View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
5 years, 10 months ago (2014-04-16 15:00:58 UTC) #1
Wladimir Palant
5 years, 10 months ago (2014-04-16 17:25:39 UTC) #2
LGTM with the nit fixed

http://codereview.adblockplus.org/6235761431019520/diff/5629499534213120/back...
File background.js (right):

http://codereview.adblockplus.org/6235761431019520/diff/5629499534213120/back...
background.js:477: function getUserFilter()
Nit: getUserFilters() please (plural)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5