Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 6236544096534528: Issue 2578 - Refactored and added missing hidden import (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Sebastian Noack
Modified:
4 years, 9 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2578 - Refactored and added missing hidden import

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M cms/bin/test_server.py View 1 chunk +5 lines, -4 lines 0 comments Download
M runserver.py View 1 chunk +0 lines, -10 lines 2 comments Download
M runserver.spec View 1 chunk +23 lines, -3 lines 5 comments Download

Messages

Total messages: 7
Sebastian Noack
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.py File runserver.py (left): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.py#oldcode2 runserver.py:2: # This is a stub script loading test_server module, ...
4 years, 9 months ago (2015-05-22 21:19:27 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.py File runserver.py (left): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.py#oldcode2 runserver.py:2: # This is a stub script loading test_server module, ...
4 years, 9 months ago (2015-05-22 21:20:10 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec#newcode15 runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)] Shouldn't we remove _hidden_imports.py ...
4 years, 9 months ago (2015-05-26 10:46:31 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec#newcode15 runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)] On 2015/05/26 10:46:31, Wladimir ...
4 years, 9 months ago (2015-05-26 11:13:57 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec#newcode15 runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)] On 2015/05/26 11:13:57, Sebastian ...
4 years, 9 months ago (2015-05-26 11:24:43 UTC) #5
Sebastian Noack
http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec File runserver.spec (right): http://codereview.adblockplus.org/6236544096534528/diff/5629499534213120/runserver.spec#newcode15 runserver.spec:15: a.scripts -= [('_hidden_imports', None, None)] On 2015/05/26 11:24:43, Wladimir ...
4 years, 9 months ago (2015-05-26 11:37:39 UTC) #6
Wladimir Palant
4 years, 9 months ago (2015-05-26 11:43:48 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5