Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(353)

Issue 6238034718621696: Issue 2483 - Give Adblock Browser its own app ID (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Felix Dahlke
Modified:
4 years, 6 months ago
Reviewers:
Wladimir Palant
CC:
René Jeschke
Visibility:
Public.

Description

Issue 2483 - Give Adblock Browser its own app ID Adblock Browser hasn't been announced yet, so we can't land the patches for issue 2509 and 2510 yet. For now, we have to apply them during the build process.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address comments #

Total comments: 5

Patch Set 3 : Address additional comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -14 lines) Patch
M adblockplus/build.py View 1 2 1 chunk +34 lines, -8 lines 0 comments Download
A adblockplus/issue-2509.patch View 1 chunk +19 lines, -0 lines 0 comments Download
A adblockplus/issue-2510.patch View 1 1 chunk +154 lines, -0 lines 0 comments Download
M mobile/android/build.mk View 1 chunk +2 lines, -5 lines 0 comments Download
M mobile/android/confvars.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
Felix Dahlke
Put René in CC since he'll be on holiday since Monday. http://codereview.adblockplus.org/6238034718621696/diff/5629499534213120/mobile/android/build.mk File mobile/android/build.mk (right): ...
4 years, 6 months ago (2015-05-14 15:24:51 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6238034718621696/diff/5629499534213120/adblockplus/build.py File adblockplus/build.py (right): http://codereview.adblockplus.org/6238034718621696/diff/5629499534213120/adblockplus/build.py#newcode14 adblockplus/build.py:14: os.mkdir(xpi_dir) os.makedirs() please - you don't know whether its ...
4 years, 6 months ago (2015-05-15 19:16:16 UTC) #2
Felix Dahlke
New patch set is up. http://codereview.adblockplus.org/6238034718621696/diff/5629499534213120/adblockplus/build.py File adblockplus/build.py (right): http://codereview.adblockplus.org/6238034718621696/diff/5629499534213120/adblockplus/build.py#newcode14 adblockplus/build.py:14: os.mkdir(xpi_dir) On 2015/05/15 19:16:16, ...
4 years, 6 months ago (2015-05-15 22:09:08 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6238034718621696/diff/5685265389584384/adblockplus/build.py File adblockplus/build.py (right): http://codereview.adblockplus.org/6238034718621696/diff/5685265389584384/adblockplus/build.py#newcode28 adblockplus/build.py:28: sys.exit(1) Exiting without an error message is strange, why ...
4 years, 6 months ago (2015-05-18 11:01:22 UTC) #4
Wladimir Palant
4 years, 6 months ago (2015-05-18 11:01:23 UTC) #5
Felix Dahlke
That should be it I hope :) http://codereview.adblockplus.org/6238034718621696/diff/5685265389584384/adblockplus/build.py File adblockplus/build.py (right): http://codereview.adblockplus.org/6238034718621696/diff/5685265389584384/adblockplus/build.py#newcode28 adblockplus/build.py:28: sys.exit(1) On ...
4 years, 6 months ago (2015-05-18 19:43:28 UTC) #6
Wladimir Palant
4 years, 6 months ago (2015-05-18 19:48:31 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5