Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 6241284884791296: issue #660 - Switch to version 2 of the HTTP cache API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by saroyanm
Modified:
5 years, 8 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is related to current ticket: https://issues.adblockplus.org/ticket/660

Patch Set 1 #

Total comments: 20

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M chrome/content/ui/sidebar.js View 1 2 2 chunks +44 lines, -24 lines 0 comments Download

Messages

Total messages: 7
saroyanm
Wladimir can you please have a look. http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode31 chrome/content/ui/sidebar.js:31: var cacheStorageSession ...
5 years, 8 months ago (2014-07-01 08:37:37 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode22 chrome/content/ui/sidebar.js:22: ({LoadContextInfo}) = Cu.import("resource://gre/modules/LoadContextInfo.jsm", {}); Please use null rather than ...
5 years, 8 months ago (2014-07-01 11:58:33 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode312 chrome/content/ui/sidebar.js:312: cacheStorageSession = cacheService.diskCacheStorage(LoadContextInfo.default, false); From the source code it ...
5 years, 8 months ago (2014-07-01 12:00:45 UTC) #3
saroyanm
Uploaded a new patch. http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode22 chrome/content/ui/sidebar.js:22: ({LoadContextInfo}) = Cu.import("resource://gre/modules/LoadContextInfo.jsm", {}); On ...
5 years, 8 months ago (2014-07-01 16:45:46 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode308 chrome/content/ui/sidebar.js:308: //Use cache V2 API from Gecko 32 Unfortunately, checking ...
5 years, 8 months ago (2014-07-02 05:00:03 UTC) #5
saroyanm
New patch uploaded http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): http://codereview.adblockplus.org/6241284884791296/diff/5629499534213120/chrome/content/ui/sidebar.js#newcode312 chrome/content/ui/sidebar.js:312: cacheStorageSession = cacheService.diskCacheStorage(LoadContextInfo.default, false); On 2014/07/02 ...
5 years, 8 months ago (2014-07-02 07:03:41 UTC) #6
Wladimir Palant
5 years, 8 months ago (2014-07-03 15:08:57 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5