Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6257417939582976: Issue 2081 - Hide "Block element" option in the popup if the page is whitelisted (Closed)

Created:
March 3, 2015, 4:37 p.m. by Sebastian Noack
Modified:
March 4, 2015, 1:12 p.m.
Reviewers:
kzar, Wladimir Palant
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 2081 - Hide "Block element" option in the popup if the page is whitelisted

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M popup.js View 2 chunks +2 lines, -3 lines 0 comments Download
M skin/popup.css View 2 chunks +5 lines, -4 lines 1 comment Download

Messages

Total messages: 3
Sebastian Noack
March 3, 2015, 4:38 p.m. (2015-03-03 16:38:24 UTC) #1
kzar
LGTM
March 4, 2015, 10:32 a.m. (2015-03-04 10:32:51 UTC) #2
Wladimir Palant
March 4, 2015, 1:12 p.m. (2015-03-04 13:12:05 UTC) #3
LGTM

http://codereview.adblockplus.org/6257417939582976/diff/5629499534213120/skin...
File skin/popup.css (right):

http://codereview.adblockplus.org/6257417939582976/diff/5629499534213120/skin...
skin/popup.css:33: body.disabled #clickhide
Nit: It's better to set this kind of classes on document.documentElement and use
:root here - setting it on document body makes unnecessary assumptions about the
document already, in addition to being less efficient IMHO. Given that this is
already a consistent pattern here however, it's a separate issue.

Powered by Google App Engine
This is Rietveld