Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(460)

Issue 6269682487132160: Issue 2151 - Drop hiera/private in favor of modules/private/hiera (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by mathias
Modified:
5 years ago
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2154

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M .hgignore View 1 chunk +0 lines, -1 line 0 comments Download
M README.md View 1 chunk +0 lines, -18 lines 0 comments Download
M Vagrantfile View 1 chunk +1 line, -1 line 0 comments Download
M hiera/hiera.yaml View 1 chunk +7 lines, -7 lines 0 comments Download
M hiera/install_precise.py View 1 chunk +3 lines, -1 line 1 comment Download
M hiera/puppet_node_classifier.rb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mathias
5 years ago (2015-03-17 09:06:40 UTC) #1
mathias
http://codereview.adblockplus.org/6269682487132160/diff/5629499534213120/hiera/install_precise.py File hiera/install_precise.py (right): http://codereview.adblockplus.org/6269682487132160/diff/5629499534213120/hiera/install_precise.py#newcode103 hiera/install_precise.py:103: config = os.path.join(dirname, 'hiera.yaml') This is actually a bug ...
5 years ago (2015-03-17 09:28:48 UTC) #2
Felix Dahlke
5 years ago (2015-03-17 09:32:08 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5