Issue 1144 - Generate IE update manifests

sitescripts/extensions/bin/updateUpdateManifests.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 """
 Generate update manifests
 =========================
 
   This script generates update manifests for all extensions and apps
 """
 
+import os
 import re
 import subprocess
 from buildtools.packagerGecko import KNOWN_APPS
 from ConfigParser import SafeConfigParser
 from sitescripts.utils import get_config, get_template
-from sitescripts.extensions.utils import (Configuration, getDownloadLinks,
-                                          getSafariCertificateID)
+from sitescripts.extensions.utils import (
+  Configuration, getDownloadLinks, getSafariCertificateID,
+  writeIEUpdateManifest)
 from sitescripts.extensions.android import get_min_sdk_version
 
 def readMetadata(repo, version):
   """
   reads extension ID and compatibility information from metadata file in the
   extension's repository
   """
   if repo.type == 'android':
     command = ['hg', '-R', repo.repository, 'id', '-r', version, '-n']
     result = subprocess.check_output(command)
@@ skipping 16 matching lines @@
     result = {
       'extensionID': metadata.get('general', 'id'),
       'version': version,
       'compat': []
     }
     for key, value in KNOWN_APPS.iteritems():
       if metadata.has_option('compat', key):
         minVersion, maxVersion = metadata.get('compat', key).split('/')
         result['compat'].append({'id': value, 'minVersion': minVersion, 'maxVersion': maxVersion})
     return result
+  elif repo.type == 'ie':
+    return {
+      'version': version,
+      'basename': os.path.basename(repo.repository)

[Felix Dahlke, 2014/07/29 15:10:27]

That's a hack if there ever was one, don't think we want to keep this. The only
alternative I see is to add a setting for this - do you know a better way?

[Felix Dahlke, 2014/07/30 14:22:36]

So, are you actually OK with this? Well, it does work.

[Wladimir Palant, 2014/07/30 14:37:50]

Of course, it is a hack. However, there isn't really a way around it right now -
IE and Android don't have a metadata file that we could extract the basename
from. So at this point there isn't much we can do. Ideally, we would support IE
and Android in build tools properly.

+    }
   else:
     raise Exception('unknown repository type %r' % repo.type)
 
 def writeUpdateManifest(links):
   """
   writes an update manifest for all extensions and Android apps
   """
 
-  extensions = {'gecko': [], 'android': [], 'safari': []}
+  extensions = {'gecko': [], 'android': [], 'safari': [], 'ie': []}
   for repo in Configuration.getRepositoryConfigurations():
     if repo.type not in extensions or not links.has_section(repo.repositoryName):
       continue
     data = readMetadata(repo, links.get(repo.repositoryName, 'version'))
     data['updateURL'] = links.get(repo.repositoryName, 'downloadURL')
     if data['updateURL'].startswith(repo.downloadsURL):
       data['updateURL'] += "?update"
     extensions[repo.type].append(data)
 
   if len(extensions['android']) > 1:
     print >>sys.stderr, 'Warning: more than one Android app defined, update manifest only works for one'
 
   for repoType in extensions.iterkeys():
     manifestPath = get_config().get('extensions', '%sUpdateManifestPath' % repoType)
-    template = get_template(get_config().get('extensions', '%sUpdateManifest' % repoType))
-    template.stream({'extensions': extensions[repoType]}).dump(manifestPath)
+    if repoType == 'ie':
+      writeIEUpdateManifest(manifestPath, extensions[repoType])
+    else:
+      template = get_template(get_config().get('extensions', '%sUpdateManifest' % repoType))
+      template.stream({'extensions': extensions[repoType]}).dump(manifestPath)
 
 def updateUpdateManifests():
   """
   updates all update manifests with the current versions
   """
 
   parser = SafeConfigParser()
   getDownloadLinks(parser)
   writeUpdateManifest(parser)
 
 if __name__ == "__main__":
   updateUpdateManifests()