sitescripts/extensions/template/ie-update.json - Issue 6270530592178176: Issue 1144 - Generate IE update manifests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/extensions/template/ie-update.json

Issue 6270530592178176: Issue 1144 - Generate IE update manifests (Closed)

Patch Set: Created July 25, 2014, 1:06 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 {%- for extension in extensions %}

	3 "{{extension.name}}/msie32": {
	Wladimir Palant 2014/07/29 11:25:18 At the very least this needs proper escaping (json At the very least this needs proper escaping (json template filter). However, it is generally a very bad idea to use templates to produce JSON code, it's too easy to break the syntax. Felix Dahlke 2014/07/29 11:37:17 The same could be said for XML, does that mean you Show quoted text On 2014/07/29 11:25:18, Wladimir Palant wrote: > At the very least this needs proper escaping (json template filter). However, it > is generally a very bad idea to use templates to produce JSON code, it's too > easy to break the syntax. The same could be said for XML, does that mean you'd like to move away from templates in general?
	4 "url": "{{extension.updateURL\|replace('.exe', '-x64.msi')}}",

	5 "version": "{{extension.version}}"

	6 },

	7 "{{extension.name}}/msie64": {

	8 "url": "{{extension.updateURL\|replace('.exe', '-x86.msi')}}",

	9 "version": "{{extension.version}}"

	10 },

	11 {%- endfor %}

	12 }

OLD	NEW