Issue 505 - [Typed objects] Implement array helper methods

lib/typedObjects/arrayTypes.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 146 matching lines @@
         }
         else
         {
           // This array is too large, it needs an individual buffer
           bufferIndex = addBuffer(referenceLength * newSize, buffers, viewTypes, views);
         }
 
         if (size > 0)
         {
           let copyBytes = length * referenceLength;
-          let src = Uint8Array(buffers[this.arrayBufferIndex], this.arrayByteOffset, copyBytes);
-          let dst = Uint8Array(buffers[bufferIndex], byteOffset, copyBytes);
+          let src = new Uint8Array(buffers[this.arrayBufferIndex], this.arrayByteOffset, copyBytes);
+          let dst = new Uint8Array(buffers[bufferIndex], byteOffset, copyBytes);
           dst.set(src);
         }
 
         this.arrayBufferIndex = bufferIndex;
         this.arrayByteOffset = byteOffset;
       }
       else
         this.arrayBufferIndex = -1;
 
       if (size > 0)
@@ skipping 30 matching lines @@
   let result = this.get(length - 1);
   this.length = this.length - 1;
   return result;
 }
 
 function splice(index, count)
 {
   index = index | 0;
   count = count | 0;
   let length = this.length | 0;
   if (index < 0)

[René Jeschke, 2014/05/19 08:35:53]

What about the negative indexing one can use on 'splice'? 

So:
if (index < 0)
{
  index += length;
  if (index < 0)
    index = 0;
}

[Wladimir Palant, 2014/05/19 15:22:02]

You are right, I wasn't aware that splice supported this - fixed.

-    index = 0;
+  {
+    index += length;
+    if (index < 0)
+      index = 0;
+  }
   if (index > length)
     index = length;
   if (index + count > length)
     count = length - index;
 
   let newCount = (arguments.length | 0) - 2;
   let diff = newCount - count;
   let newLength = length + diff;
   if (diff > 0)
   {
@@ skipping 106 matching lines @@
     meta.watch = {};
 
   meta.watch.length = createLengthWatcher(elementType, elementSetter);
   meta.watch.size = createSizeWatcher(elementType, minElements, bufferSize, buffers, viewTypes, views, firstFree);
 
   let {ObjectBase} = require("typedObjects/objectTypes");
   return ObjectBase.extend(typeDescriptor, meta);
 }
 
 exports.createArrayType = createArrayType;