Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(399)

Issue 6276084194607104: Issue 338 - Updated minimum version to Chrome 28 and got rid of legacy compatibility code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by Sebastian Noack
Modified:
5 years, 10 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M chrome/ext/background.js View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/ext/common.js View 1 chunk +1 line, -25 lines 0 comments Download
M chrome/ext/content.js View 1 chunk +4 lines, -1 line 0 comments Download
M metadata.chrome View 1 chunk +1 line, -1 line 0 comments Download
M popupBlocker.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5
Sebastian Noack
5 years, 10 months ago (2014-04-16 09:58:00 UTC) #1
Wladimir Palant
LGTM with the webNavigation change reverted. http://codereview.adblockplus.org/6276084194607104/diff/5629499534213120/popupBlocker.js File popupBlocker.js (right): http://codereview.adblockplus.org/6276084194607104/diff/5629499534213120/popupBlocker.js#newcode18 popupBlocker.js:18: if (require("info").platform == ...
5 years, 10 months ago (2014-04-16 10:12:16 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6276084194607104/diff/5629499534213120/popupBlocker.js File popupBlocker.js (right): http://codereview.adblockplus.org/6276084194607104/diff/5629499534213120/popupBlocker.js#newcode18 popupBlocker.js:18: if (require("info").platform == "chromium") On 2014/04/16 10:12:16, Wladimir Palant ...
5 years, 10 months ago (2014-04-16 10:14:10 UTC) #3
Wladimir Palant
Seeing that we use webNavigation elsewhere as well, I guess the patch is fine as ...
5 years, 10 months ago (2014-04-16 10:14:23 UTC) #4
Wladimir Palant
5 years, 10 months ago (2014-04-16 10:25:17 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5