Issue 338 - Updated minimum version to Chrome 28 and got rid of legacy compatibility code

popupBlocker.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-if (require("info").platform == "chromium" && "webNavigation" in chrome)
+if (require("info").platform == "chromium")

[Wladimir Palant, 2014/04/16 10:12:16]

I think that this will break older Opera versions - they didn't have support for
webNavigation API even though the underlying Chromium version did.

[Sebastian Noack, 2014/04/16 10:14:11]

Yes, this requires Opera >=17. However we are already using the webNavigation
API in other code without checking.

 {
   var tabsLoading = {};
 
   chrome.webNavigation.onCreatedNavigationTarget.addListener(function(details)
   {
     var sourcePage = new ext.Page({id: details.sourceTabId});
     var sourceFrame = ext.getFrame(details.sourceTabId, details.sourceFrameId);
 
     if (!sourceFrame || isFrameWhitelisted(sourcePage, sourceFrame))
       return;
@@ skipping 27 matching lines @@
 
 function checkPotentialPopup(tabId, url, opener)
 {
   var requestHost = extractHostFromURL(url);
   var documentHost = extractHostFromURL(opener);
   var thirdParty = isThirdParty(requestHost, documentHost);
   var filter = defaultMatcher.matchesAny(url || "about:blank", "POPUP", documentHost, thirdParty);
   if (filter instanceof BlockingFilter)
     chrome.tabs.remove(tabId);
 }