Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(342)

Issue 6280417539784704: Issue 101 - Fix policy tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by tschuster
Modified:
5 years, 4 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

We had some race condition between when the iframe loaded and when the dynamic image or Worker actually finished loading.

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -34 lines) Patch
M chrome/content/tests/policy.js View 1 4 chunks +47 lines, -34 lines 1 comment Download

Messages

Total messages: 5
tschuster
5 years, 5 months ago (2014-07-09 17:04:05 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6280417539784704/diff/5629499534213120/chrome/content/tests/policy.js File chrome/content/tests/policy.js (right): http://codereview.adblockplus.org/6280417539784704/diff/5629499534213120/chrome/content/tests/policy.js#newcode205 chrome/content/tests/policy.js:205: if (!item) { Nit: opening { belongs onto the ...
5 years, 5 months ago (2014-07-09 18:48:32 UTC) #2
tschuster
I think I forgot to set that -p flag again. r?
5 years, 4 months ago (2014-07-14 13:21:58 UTC) #3
Wladimir Palant
LGTM with the issue below addressed. http://codereview.adblockplus.org/6280417539784704/diff/5724160613416960/chrome/content/tests/policy.js File chrome/content/tests/policy.js (right): http://codereview.adblockplus.org/6280417539784704/diff/5724160613416960/chrome/content/tests/policy.js#newcode307 chrome/content/tests/policy.js:307: frame.addEventListener("load", callback, true, ...
5 years, 4 months ago (2014-07-14 13:33:54 UTC) #4
tschuster
5 years, 4 months ago (2014-07-16 15:41:25 UTC) #5
Wasn't necessary!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5