Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6282067956465664: Issue 399 - Added support for Safari to updateDownloadLinks (Closed)

Created:
April 30, 2014, 11:43 a.m. by Sebastian Noack
Modified:
April 30, 2014, 12:26 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 399 - Added support for Safari to updateDownloadLinks

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -41 lines) Patch
M .sitescripts.example View 1 chunk +1 line, -0 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 2 chunks +4 lines, -22 lines 0 comments Download
M sitescripts/extensions/bin/updateDownloadLinks.py View 1 4 chunks +40 lines, -19 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
April 30, 2014, 11:45 a.m. (2014-04-30 11:45:01 UTC) #1
Wladimir Palant
LGTM, feel free to address the nits however. http://codereview.adblockplus.org/6282067956465664/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py File sitescripts/extensions/bin/updateDownloadLinks.py (right): http://codereview.adblockplus.org/6282067956465664/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py#newcode186 sitescripts/extensions/bin/updateDownloadLinks.py:186: result ...
April 30, 2014, 11:50 a.m. (2014-04-30 11:50:57 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6282067956465664/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py File sitescripts/extensions/bin/updateDownloadLinks.py (right): http://codereview.adblockplus.org/6282067956465664/diff/5629499534213120/sitescripts/extensions/bin/updateDownloadLinks.py#newcode186 sitescripts/extensions/bin/updateDownloadLinks.py:186: result = subprocess.check_output(command) On 2014/04/30 11:50:57, Wladimir Palant wrote: ...
April 30, 2014, 12:21 p.m. (2014-04-30 12:21:45 UTC) #3
Wladimir Palant
April 30, 2014, 12:23 p.m. (2014-04-30 12:23:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld