disable acceptable ads from first run page

lib/appSupport.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * @fileOverview Various application-specific functions.
  */
 
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
 Cu.import("resource://gre/modules/Services.jsm");
+Cu.import("resource://gre/modules/AddonManager.jsm");
 
 /**
  * Checks whether an application window is known and should get Adblock Plus
  * user interface elements.
  * @result Boolean
  */
 exports.isKnownWindow = function isKnownWindow(/**Window*/ window) false;
 
 /**
  * HACK: In some applications the window finishes initialization during load
@@ skipping 886 matching lines @@
     UI.openFiltersDialog = function()
     {
       let window = UI.currentWindow;
       if (!window)
         return
       
       let browser = exports.addTab(window, "about:addons").browser;
       browser.addEventListener("load", function openAddonPrefs(event) 
       {
         browser.removeEventListener("load", openAddonPrefs, true);
-        Utils.runAsync(function(state)
-        {
-          let event = new Event("Event");
-          event.initEvent("popstate", true, false);
-          event.state = state;
-          browser._contentWindow.dispatchEvent(event);
-        }, this, {id: require("info").addonID});

[Wladimir Palant, 2014/05/02 16:36:47]

Passing in this and the state parameter is unnecessary - just use
require("info") inside the function as before.

For reference: new code shouldn't use Utils.runAsync() with more than one
parameter, that's what Function.bind() is good for (it didn't exist back when
Utils.runAsync() was written).

[saroyanm, 2014/05/03 08:02:06]

My bad that I didn't left comment on this. 
When I was declaring require("info") inside the function I was getting current
Error (In 3/5 tests) :
TypeError: aListItem is null
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/a...

I thought it's somehow connected with async function.

Actually Now seams like that I'm not getting that error anymore, not sure why.. 
Tested around 10 times and only 1-st time got that error (Have a doubt that it
was because of cache). I've changed declaration as it was before, if you can
drop a comment on this Wladimir, I will really appreciate that.

P.S. For the parameters in runAsync() function, will keep in mind for future.
Thanks.

[Wladimir Palant, 2014/05/03 17:54:18]

That's indeed an issue. The list of add-ons is being filled by Addons.init()
which calls the asynchronous method AddonManager.getAddonsByTypes(). The first
time it is called the add-on manager will read the information from disk which
takes some time - so we dispatch our popstate event too early, the list hasn't
been filled yet.

I don't see any good way to solve this issue, there is no event that we can
listen to in order to see that the list has been filled. And using some timeout
value is always error-prone - we have no idea how much time this operation might
take on a mobile device.

If anything, we could call  AddonManager.getAddonsByTypes(["extension", "theme",
"locale"], callback) ourselves and dispatch the event in the callback. However,
I doubt that this is a reliable solution. Want to try this?

[saroyanm, 2014/05/04 14:05:08]

Thanks for descriptive answer Wladimir, 
I also have a doubt of using that method, but while there seams not to be any
better solution, that solution is better then patch #4.
As you already mentioned addons list is being populated in callback function of
AddonManager.getAddonsByTypes:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/a...

So seams like with this solution we saving time and it works more reliable then
the previous one after my tests.

+        Utils.runAsync(function()
+        {
+          // The page won't be ready until the add-on manager data is loaded so we call this method
+          // to know when the data will be ready.
+          AddonManager.getAddonsByTypes(["extension", "theme", "locale"], function()
+          {
+            let event = new Event("Event");
+            event.initEvent("popstate", true, false);
+            event.state = {id: require("info").addonID};
+            browser._contentWindow.dispatchEvent(event);
+          });
+        });
       }, true);
     };
 
     break;
   }
 }