Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 6287762160353280: Fixed: patterns.ini contents are being processed multiple times (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by Wladimir Palant
Modified:
5 years, 8 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/152 - our own code handles reentrance just fine, XMLHttpRequest however doesn`t. If a new progress event fires while the previous one is still being processed request.response isn`t being reset. The solution is to decouple our event processing using Utils.runAsync. While at it, it seems that error reporting was always broken here - fixed it.

Patch Set 1 #

Patch Set 2 : Fixed typo #

Patch Set 3 : Fixed error reporting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M lib/io.js View 1 2 4 chunks +30 lines, -24 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
5 years, 8 months ago (2014-03-16 21:29:52 UTC) #1
Wladimir Palant
Fixed typo
5 years, 8 months ago (2014-03-16 21:40:08 UTC) #2
Wladimir Palant
Fixed error reporting
5 years, 8 months ago (2014-03-16 21:49:54 UTC) #3
Felix Dahlke
5 years, 8 months ago (2014-03-18 07:08:53 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5