Issue #276 - eliminate CString from GetDataPath

src/plugin/PluginSettings.h

 /**
 * This class contains all client functionality of the IE plugin
 *
 * Exception errors are tested by calls to ExceptionsTest from: Main ...
 */
 
 #ifndef _PLUGIN_SETTINGS_H_
 #define _PLUGIN_SETTINGS_H_
 
 
@@ skipping 52 matching lines @@
   CPluginSettings();
 public:
 
   ~CPluginSettings();
 
   static CPluginSettings* s_instance;
 
   static bool HasInstance();
   static CPluginSettings* GetInstance();
 
-  static CString GetDataPath(const CString& filename=L"");
-
   bool IsPluginEnabled() const;
 
   std::map<CString, CString> GetFilterLanguageTitleList() const;
 
   void SetWorkingThreadId();
   void SetWorkingThreadId(DWORD id);
   bool IsWorkingThread(DWORD dwThread=0) const;
 
   DWORD m_WindowsBuildNumber;
 
@@ skipping 23 matching lines @@
   bool RefreshWhitelist();
   DWORD GetWindowsBuildNumber();
 
   void SetSubscription(const std::wstring& url);
   void SetDefaultSubscription();
   CString GetSubscription();
   CString GetAppLocale();
   CString GetDocumentationLink();
 };
 
+std::wstring GetDataPath(const std::wstring& filename=L"");

[Oleksandr, 2014/08/05 12:06:08]

If it's not a member of a class I'd move it elsewhere (Utils maybe?). But I
really don't mind having it as a static method. Even though it's not using any
static variables. 

[Eric, 2014/08/05 15:42:07]

There are a bunch of static functions like this that don't need to be static.
They're not really utilities but rather more application-specific. They might
better go elsewhere, I agree, but it can also go in a separate change set,
similar to GetBrowserLanguage(), orphaned with the removal of CPluginSystem.
It used to be in C++ that you'd use static class methods as a substitute for a
namespace. These days we have explicit namespaces, which is what I'd recommend
here.

The function in question is about the installation context of the plugin. Since
installation tends to act like global variables, with all their attendant
issues, it's usually a good idea to mark its occurrences somehow.

We can make all these decisions later, though, both what file to put the code it
and what namespace to use.

 
 #endif // _PLUGIN_SETTINGS_H_