Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6289768170127360: Issue 2067 - Unify logic retrieving the UI locale (Closed)

Created:
March 1, 2015, 12:55 p.m. by Sebastian Noack
Modified:
March 3, 2015, 8:32 a.m.
Reviewers:
Wladimir Palant
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 2067 - Unify logic retrieving the UI locale

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed: There is no ext.i18n in the background page on Firefox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M i18n.js View 1 chunk +11 lines, -14 lines 0 comments Download
M messageResponder.js View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 1, 2015, 12:56 p.m. (2015-03-01 12:56:41 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6289768170127360/diff/5629499534213120/messageResponder.js File messageResponder.js (right): http://codereview.adblockplus.org/6289768170127360/diff/5629499534213120/messageResponder.js#newcode113 messageResponder.js:113: var bidiDir = ext.i18n.getMessage("@@bidi_dir"); ext.i18n is purely content side ...
March 2, 2015, 11:40 a.m. (2015-03-02 11:40:51 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6289768170127360/diff/5629499534213120/messageResponder.js File messageResponder.js (right): http://codereview.adblockplus.org/6289768170127360/diff/5629499534213120/messageResponder.js#newcode113 messageResponder.js:113: var bidiDir = ext.i18n.getMessage("@@bidi_dir"); On 2015/03/02 11:40:51, Wladimir Palant ...
March 2, 2015, 11:56 a.m. (2015-03-02 11:56:03 UTC) #3
Wladimir Palant
March 2, 2015, 12:07 p.m. (2015-03-02 12:07:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld