Issue 1093 - Separate update manifest generation

sitescripts/extensions/utils.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 264 matching lines @@
     except IOError, e:
       error = e
       time.sleep(5)
   raise error
 
 def _getMozillaDownloadLink(galleryID):
   """
   gets download link for a Gecko add-on from the Mozilla Addons site
   """
   url = 'https://services.addons.mozilla.org/en-US/firefox/api/1/addon/%s' % _urlencode(galleryID)
-  contents = _urlopen(url).read()
-  document = dom.parseString(contents)

[Wladimir Palant, 2014/07/22 18:41:22]

This isn't something you changed but please replace the two lines above with:

  document = dom.parse(_urlopen(url))

This is probably why the download from Mozilla fails occasionally - read() isn't
guaranteed to read until the end of stream.

[Felix Dahlke, 2014/07/23 04:52:17]

Done.

+  document = dom.parse(_urlopen(url))
   linkTags = document.getElementsByTagName('install')
   linkTag = linkTags[0] if len(linkTags) > 0 else None
   versionTags = document.getElementsByTagName('version')
   versionTag = versionTags[0] if len(versionTags) > 0 else None
   if linkTag and versionTag and linkTag.firstChild and versionTag.firstChild:
     return (linkTag.firstChild.data, versionTag.firstChild.data)
   else:
     return (None, None)
 
 def _getGoogleDownloadLink(galleryID):
@@ skipping 94 matching lines @@
     if downloadURL == None:
       continue
     if not result.has_section(repo.repositoryName):
       result.add_section(repo.repositoryName)
     result.set(repo.repositoryName, "downloadURL", downloadURL)
     result.set(repo.repositoryName, "version", version)
 
     qrcode = _getQRCode(downloadURL)
     if qrcode != None:
       result.set(repo.repositoryName, "qrcode", qrcode)