Issue 1093 - Separate update manifest generation

sitescripts/extensions/bin/updateDownloadLinks.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 """
 Update the list of extenstions
 ==============================
 
   This script generates a list of extensions and saves these with download links
   and version information
 """
 
-import sys, os, re, urllib, urllib2, subprocess, time

[Wladimir Palant, 2014/07/22 11:24:26]

sys, os, subprocess are no longer being used here. Please convert this into one
import per line while at it.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

-import xml.dom.minidom as dom

[Wladimir Palant, 2014/07/22 11:24:26]

dom should no longer be required here.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

 from ConfigParser import SafeConfigParser
-from StringIO import StringIO

[Wladimir Palant, 2014/07/22 11:24:26]

StringIO is no longer being used here.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

-from sitescripts.utils import get_config, get_template

[Wladimir Palant, 2014/07/22 11:24:26]

get_template is no longer being used here.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

-from sitescripts.extensions.utils import (compareVersions, Configuration,
-  getSafariCertificateID, getDownloadLinks, readMetadata)

[Wladimir Palant, 2014/07/22 11:24:26]

compareVersions, getSafariCertificateID, readMetadata aren't being used here.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

+from sitescripts.utils import get_config
+from sitescripts.extensions.utils import Configuration, getDownloadLinks
 from sitescripts.extensions.pad import PadFile
-
-def urlencode(value):
-  return urllib.quote(value.encode('utf-8'), '')
-
-def urlopen(url, attempts=3):
-  """
-  Tries to open a particular URL, retries on failure.
-  """
-  for i in range(attempts):
-    try:
-      return urllib.urlopen(url)
-    except IOError, e:
-      error = e
-      time.sleep(5)
-  raise error
-
-def getMozillaDownloadLink(galleryID):
-  """
-  gets download link for a Gecko add-on from the Mozilla Addons site
-  """
-  url = 'https://services.addons.mozilla.org/en-US/firefox/api/1/addon/%s' % urlencode(galleryID)
-  contents = urlopen(url).read()
-  document = dom.parseString(contents)
-  linkTags = document.getElementsByTagName('install')
-  linkTag = linkTags[0] if len(linkTags) > 0 else None
-  versionTags = document.getElementsByTagName('version')
-  versionTag = versionTags[0] if len(versionTags) > 0 else None
-  if linkTag and versionTag and linkTag.firstChild and versionTag.firstChild:
-    return (linkTag.firstChild.data, versionTag.firstChild.data)
-  else:
-    return (None, None)
-
-def getGoogleDownloadLink(galleryID):
-  """
-  gets download link for a Chrome add-on from the Chrome Gallery site
-  """
-  galleryID = urlencode(galleryID)
-
-  url = 'https://clients2.google.com/service/update2/crx?x=%s' % urlencode('id=%s&uc' % galleryID)
-  document = dom.parse(urlopen(url))
-  updateTags = document.getElementsByTagName('updatecheck')
-  version = updateTags and updateTags[0].getAttribute('version')
-
-  if not version:
-    return (None, None)
-
-  request = urllib2.Request('https://chrome.google.com/webstore/detail/_/' + galleryID)
-  request.get_method = lambda : 'HEAD'
-  url = urllib2.urlopen(request).geturl()
-
-  return (url, version)
-
-def getOperaDownloadLink(galleryID):

[Wladimir Palant, 2014/07/22 11:24:26]

From the look of it, this function and the ones above it should be located in
the utils module where they are used.

[Felix Dahlke, 2014/07/22 12:01:11]

Done.

-  """
-  gets download link for an Opera add-on from the Opera Addons site
-  """
-  galleryID = urlencode(galleryID)
-
-  request = urllib2.Request('https://addons.opera.com/extensions/download/%s/' % galleryID)
-  request.get_method = lambda : 'HEAD'
-  response = urllib2.urlopen(request)
-
-  content_disposition = response.info().getheader('Content-Disposition')
-  if content_disposition:
-    match = re.search(r'filename=\S+-([\d.]+)-\d+\.crx$', content_disposition)
-    if match:
-      return ('https://addons.opera.com/extensions/details/%s/' % galleryID , match.group(1))
-
-  return (None, None)
 
 def writePadFile(links):
   for repo in Configuration.getRepositoryConfigurations():
     if repo.pad and links.has_section(repo.repositoryName):
       PadFile.forRepository(repo, links.get(repo.repositoryName, 'version'),
                                   links.get(repo.repositoryName, 'downloadURL')).write()
 
 def updateLinks():
   """
   writes the current extension download links to a file
   """
 
   # Now get download links and save them to file
   result = SafeConfigParser()
   getDownloadLinks(result)
   file = open(get_config().get('extensions', 'downloadLinksFile'), 'wb')
   result.write(file)
   file.close()
 
   writePadFile(result)
 
 if __name__ == "__main__":
   updateLinks()