Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6293281981857792: Issue 239 - Move AWStats processing to the stats server (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Wladimir Palant
Modified:
5 years, 6 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 239 - Move AWStats processing to the stats server

Patch Set 1 #

Total comments: 15

Patch Set 2 : Added IP address anonymization and addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -50 lines) Patch
M manifests/intraforumserver.pp View 1 1 chunk +1 line, -1 line 0 comments Download
M modules/statsmaster/files/known_hosts View 1 1 chunk +1 line, -0 lines 0 comments Download
M modules/statsmaster/files/site.conf View 1 1 chunk +1 line, -1 line 0 comments Download
M modules/statsmaster/manifests/awstats.pp View 1 4 chunks +24 lines, -38 lines 0 comments Download
M modules/statsmaster/manifests/downloads.pp View 1 2 chunks +3 lines, -8 lines 0 comments Download
A modules/statsmaster/templates/anonymize_ips_head.erb View 1 1 chunk +12 lines, -0 lines 0 comments Download
A modules/statsmaster/templates/anonymize_ips_item.erb View 1 1 chunk +27 lines, -0 lines 0 comments Download
M modules/statsmaster/templates/awstats.conf View 1 1 chunk +1 line, -1 line 0 comments Download
M modules/statsmaster/templates/build_static_head.erb View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
5 years, 6 months ago (2014-04-23 13:14:33 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/manifests/intraforumserver.pp File manifests/intraforumserver.pp (right): http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/manifests/intraforumserver.pp#newcode2 manifests/intraforumserver.pp:2: include base, ssh, statsclient Leaving ssh here was a ...
5 years, 6 months ago (2014-04-24 10:01:04 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/files/known_hosts File modules/statsmaster/files/known_hosts (right): http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/files/known_hosts#newcode4 modules/statsmaster/files/known_hosts:4: server_7.adblockplus.org,88.198.50.132,2a01:4f8:131:2144::2 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBDKYm9Ajuo3BOVhc/UCTzc76MHHqAs/szmj1APDyVMq6/7XROEEB6qQ1uuaijNQBBy7PylbG9tYbkUTNRrqt7mg= server_10 is missing here, fixed that ...
5 years, 6 months ago (2014-04-24 18:57:03 UTC) #3
Felix Dahlke
Looks good, some comments. http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/files/site.conf File modules/statsmaster/files/site.conf (right): http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/files/site.conf#newcode40 modules/statsmaster/files/site.conf:40: autoindex on; # for the ...
5 years, 6 months ago (2014-04-25 04:37:08 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/templates/awstats.conf File modules/statsmaster/templates/awstats.conf (right): http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modules/statsmaster/templates/awstats.conf#newcode224 modules/statsmaster/templates/awstats.conf:224: # AWStats saves and sorts its database on a ...
5 years, 6 months ago (2014-04-25 07:40:55 UTC) #5
Felix Dahlke
5 years, 6 months ago (2014-04-25 09:42:50 UTC) #6
LGTM

http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modu...
File modules/statsmaster/templates/build_static_head.erb (right):

http://codereview.adblockplus.org/6293281981857792/diff/5629499534213120/modu...
modules/statsmaster/templates/build_static_head.erb:1: #!/usr/bin/env python
On 2014/04/25 07:40:55, Wladimir Palant wrote:
> On 2014/04/25 04:37:08, Felix H. Dahlke wrote:
> > Why is this a template? Seems to me like it could be a static file, assuming
> > concat can deal with a mixture of file and template fragments.
> 
> Sure, it can be a static file - it's merely a template to have all pieces of
the
> file in one place. Same goes for the other head/foot templates.

Fair enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5