Issue 24 - Regex: Replace Matcher.matches(...) with Matcher.find(...)

src/org/adblockplus/android/AdblockPlus.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 40 matching lines @@
 import android.net.Uri;
 import android.os.Build;
 import android.preference.PreferenceManager;
 import android.provider.Settings;
 import android.util.Log;
 
 public class AdblockPlus extends Application
 {
   private static final String TAG = Utils.getTag(AdblockPlus.class);
 
-  private static final Pattern RE_JS = Pattern.compile(".*\\.js$", Pattern.CASE_INSENSITIVE);
-  private static final Pattern RE_CSS = Pattern.compile(".*\\.css$", Pattern.CASE_INSENSITIVE);
-  private static final Pattern RE_IMAGE = Pattern.compile(".*\\.(?:gif|png|jpe?g|bmp|ico)$", Pattern.CASE_INSENSITIVE);
-  private static final Pattern RE_FONT = Pattern.compile(".*\\.(?:ttf|woff)$", Pattern.CASE_INSENSITIVE);
-  private static final Pattern RE_HTML = Pattern.compile(".*\\.html?$", Pattern.CASE_INSENSITIVE);
+  private static final Pattern RE_JS = Pattern.compile("\\.js$", Pattern.CASE_INSENSITIVE);
+  private static final Pattern RE_CSS = Pattern.compile("\\.css$", Pattern.CASE_INSENSITIVE);
+  private static final Pattern RE_IMAGE = Pattern.compile("\\.(?:gif|png|jpe?g|bmp|ico)$", Pattern.CASE_INSENSITIVE);
+  private static final Pattern RE_FONT = Pattern.compile("\\.(?:ttf|woff)$", Pattern.CASE_INSENSITIVE);
+  private static final Pattern RE_HTML = Pattern.compile("\\.html?$", Pattern.CASE_INSENSITIVE);
 
   /**
    * Update notification id.
    */
   public static final int UPDATE_NOTIFICATION_ID = R.string.app_name + 1;
   /**
    * Broadcasted when filtering is enabled or disabled.
    */
   public static final String BROADCAST_FILTERING_CHANGE = "org.adblockplus.android.filtering.status";
   /**
@@ skipping 295 matching lines @@
       if (accept.contains("text/css"))
         contentType = "STYLESHEET";
       else if (accept.contains("image/*"))
         contentType = "IMAGE";
       else if (accept.contains("text/html"))
         contentType = "SUBDOCUMENT";
     }
 
     if (contentType == null)
     {
-      if (RE_JS.matcher(url).matches())
+      if (RE_JS.matcher(url).find())
         contentType = "SCRIPT";
-      else if (RE_CSS.matcher(url).matches())
+      else if (RE_CSS.matcher(url).find())
         contentType = "STYLESHEET";
-      else if (RE_IMAGE.matcher(url).matches())
+      else if (RE_IMAGE.matcher(url).find())
         contentType = "IMAGE";
-      else if (RE_FONT.matcher(url).matches())
+      else if (RE_FONT.matcher(url).find())
         contentType = "FONT";
-      else if (RE_HTML.matcher(url).matches())
+      else if (RE_HTML.matcher(url).find())
         contentType = "SUBDOCUMENT";
     }
     if (contentType == null)
       contentType = "OTHER";
 
     final List<String> referrerChain = buildReferrerChain(referrer);
     Log.d("Referrer chain", fullUrl + ": " + referrerChain.toString());
     final String[] referrerChainArray = referrerChain.toArray(new String[referrerChain.size()]);
     return abpEngine.matches(fullUrl, contentType, referrerChainArray);
   }
@@ skipping 136 matching lines @@
       Log.e(TAG, e.getMessage(), e);
     }
 
     // Set crash handler
     Thread.setDefaultUncaughtExceptionHandler(new CrashHandler(this));
 
     // Initiate update check
     scheduleUpdater(0);
   }
 }