Fix issue with comments and thumbnails not loading on YouTube in Safari

Since we disable pushState on YouTube, the comments and thumbnails for the video in the side bar aren't loading anymore.

It turned out that this wasn't because disabling pushState, but because we changed the location to a javascript: URL for that purpose. My assumption is that this interrupts pending requests, because it doesn't matter what JavaScript code is executed. I got the same issue when just using javascript:void(0); instead. However we can still inject a script tag.

[Sebastian Noack, 2014-02-28 21:54:22]

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
File safari/include.youtube.js (right):

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
safari/include.youtube.js:74:
"document.documentElement.removeChild(document.getElementById('__disablePushState'));";
In the previous review Wladimir suggested that we should remove the script tag
from the DOM when it's not needed anymore:
http://codereview.adblockplus.org/4663448277352448/diff/5741031244955648/safa...

But Safari neither supports the onafterscriptexecuted event nor
window.currentScript. So the only way is to give the tag an ID. A randomized ID
might be preferable, but considering  that this is only on YouTube and that the
script tag is removed immediately, I preferred a hard-coded ID in favor of less
code.

[Wladimir Palant, 2014-03-03 07:21:13]

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
File safari/include.youtube.js (right):

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
safari/include.youtube.js:74:
"document.documentElement.removeChild(document.getElementById('__disablePushState'));";
Why have the script remove itself? Using |script.async = false| instead and
removing the tag immediately after inserting it should work as well.

[Sebastian Noack, 2014-03-05 11:24:01]

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
File safari/include.youtube.js (right):

http://codereview.adblockplus.org/6304200141045760/diff/5629499534213120/safa...
safari/include.youtube.js:74:
"document.documentElement.removeChild(document.getElementById('__disablePushState'));";
On 2014/03/03 07:21:13, Wladimir Palant wrote:
> Why have the script remove itself? Using |script.async = false| instead and
> removing the tag immediately after inserting it should work as well.

Done.

[Wladimir Palant, 2014-03-05 14:51:43]

LGTM

[Felix Dahlke, 2014-03-05 14:52:47]

LGTM