Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1029)

Issue 6304204159188992: Issue 1992 - createNightlies.py incorrectly determines repository name if repository path ends with… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Wladimir Palant
Modified:
4 years, 9 months ago
Visibility:
Public.

Description

Issue 1992 - createNightlies.py incorrectly determines repository name if repository path ends with…

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use os.path.normpath() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sitescripts/extensions/utils.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
4 years, 9 months ago (2015-02-12 15:01:56 UTC) #1
Felix Dahlke
LGTM
4 years, 9 months ago (2015-02-12 15:10:03 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6304204159188992/diff/5629499534213120/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): http://codereview.adblockplus.org/6304204159188992/diff/5629499534213120/sitescripts/extensions/utils.py#newcode221 sitescripts/extensions/utils.py:221: return os.path.basename(self.repository) or os.path.basename(os.path.dirname(self.repository)) How about using normpath? os.path.basename(os.path.normpath(self.repository)) ...
4 years, 9 months ago (2015-02-13 10:47:15 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6304204159188992/diff/5629499534213120/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): http://codereview.adblockplus.org/6304204159188992/diff/5629499534213120/sitescripts/extensions/utils.py#newcode221 sitescripts/extensions/utils.py:221: return os.path.basename(self.repository) or os.path.basename(os.path.dirname(self.repository)) On 2015/02/13 10:47:15, Sebastian Noack ...
4 years, 9 months ago (2015-02-13 16:45:10 UTC) #4
Felix Dahlke
LGTMer
4 years, 9 months ago (2015-02-13 17:15:53 UTC) #5
Sebastian Noack
4 years, 9 months ago (2015-02-13 17:17:17 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5