Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(363)

Issue 6305806509146112: Issue 427 - Remove non-standard function and getter syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by tschuster
Modified:
5 years, 6 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Remove non-standard function and getter syntax

Patch Set 1 #

Patch Set 2 : Convert shorthand function expressions to arrow functions, this of course isn't possible for getter… #

Total comments: 19

Patch Set 3 : Wow sorry for those wrong braces, I am so used to a different style that I didn't even realize what… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -56 lines) Patch
M .hgsubstate View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/appSupport.js View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M lib/customizableUI.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/elemHide.js View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M lib/filterClasses.js View 1 2 3 chunks +14 lines, -5 lines 0 comments Download
M lib/filterStorage.js View 1 2 4 chunks +9 lines, -6 lines 0 comments Download
M lib/io.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/requestNotifier.js View 1 2 3 chunks +14 lines, -8 lines 0 comments Download
M lib/subscriptionClasses.js View 1 2 6 chunks +33 lines, -9 lines 0 comments Download
M lib/sync.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/synchronizer.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/ui.js View 1 2 9 chunks +13 lines, -13 lines 0 comments Download
M lib/utils.js View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9
tschuster
review please
5 years, 7 months ago (2014-05-05 15:30:29 UTC) #1
Wladimir Palant
IMHO we should use fat arrow functions instead of expression closures - for the sake ...
5 years, 7 months ago (2014-05-05 15:45:40 UTC) #2
tschuster
On 2014/05/05 15:45:40, Wladimir Palant wrote: > IMHO we should use fat arrow functions instead ...
5 years, 7 months ago (2014-05-05 17:36:43 UTC) #3
Wladimir Palant
On 2014/05/05 17:36:43, tschuster wrote: > Do you want to desugar fat arrow functions to ...
5 years, 7 months ago (2014-05-05 17:59:08 UTC) #4
tschuster
Convert shorthand function expressions to arrow functions, this of course isn't possible for getter/setters
5 years, 7 months ago (2014-05-10 12:43:23 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/6305806509146112/diff/5724160613416960/lib/appSupport.js File lib/appSupport.js (right): http://codereview.adblockplus.org/6305806509146112/diff/5724160613416960/lib/appSupport.js#newcode31 lib/appSupport.js:31: exports.isKnownWindow = function isKnownWindow(/**Window*/ window) { (/**Window*/ window) => ...
5 years, 6 months ago (2014-05-15 07:12:38 UTC) #6
tschuster
Wow sorry for those wrong braces, I am so used to a different style that ...
5 years, 6 months ago (2014-05-18 10:51:34 UTC) #7
tschuster
r?
5 years, 6 months ago (2014-05-24 11:10:32 UTC) #8
Wladimir Palant
5 years, 6 months ago (2014-05-25 08:27:55 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5