Issue 427 - Remove non-standard function and getter syntax

lib/requestNotifier.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
 
 let nodeData = new WeakMap();
 let windowStats = new WeakMap();
 let windowSelection = new WeakMap();
 
 let setEntry, hasEntry, getEntry;
 if (false)
 {
   // This branch can be enabled again once all of bug 673468, bug 819131 and
   // bug 982561 are fixed and we can use weak maps.
-  setEntry = function(map, key, value) map.set(key, value);
-  hasEntry = function(map, key) map.has(key);
-  getEntry = function(map, key) map.get(key);
+  setEntry = (map, key, value) => map.set(key, value);
+  hasEntry = (map, key) => map.has(key);
+  getEntry = (map, key) => map.get(key);
 }
 else
 {
   // Fall back to user data
   let dataSeed = Math.random();
   let nodeDataProp = "abpNodeData" + dataSeed;
   let windowStatsProp = "abpWindowStats" + dataSeed;
   let windowSelectionProp = "abpWindowSelection" + dataSeed;
   let getProp = function(map)
   {
     switch (map)
     {
       case nodeData:
         return nodeDataProp;
       case windowStats:
         return windowStatsProp;
       case windowSelection:
         return windowSelectionProp;
       default:
         return null;
     }
   };
 
-  setEntry = function(map, key, value) key.setUserData(getProp(map), value, null);
-  hasEntry = function(map, key) key.getUserData(getProp(map));
-  getEntry = function(map, key) key.getUserData(getProp(map)) || undefined;
+  setEntry = (map, key, value) => key.setUserData(getProp(map), value, null);
+  hasEntry = (map, key) => key.getUserData(getProp(map));
+  getEntry = (map, key) => key.getUserData(getProp(map)) || undefined;
 }
 
 /**
  * List of notifiers in use - these notifiers need to receive notifications on
  * new requests.
  * @type RequestNotifier[]
  */
 let activeNotifiers = [];
 
 /**
@@ skipping 266 matching lines @@
   location: null,
   /**
    * Filter that was applied to this request (if any)
    * @type Filter
    */
   filter: null,
   /**
    * String representation of the content type, e.g. "subdocument"
    * @type String
    */
-  get typeDescr() require("contentPolicy").Policy.typeDescr[this.type],
+  get typeDescr() { return require("contentPolicy").Policy.typeDescr[this.type]; },

[Wladimir Palant, 2014/05/15 07:12:38]

Nit: Please add proper line breaks here.

   /**
    * User-visible localized representation of the content type, e.g. "frame"
    * @type String
    */
-  get localizedDescr() require("contentPolicy").Policy.localizedDescr[this.type],
+  get localizedDescr() { return require("contentPolicy").Policy.localizedDescr[this.type]; },

[Wladimir Palant, 2014/05/15 07:12:38]

Nit: Please add proper line breaks here.

 
   /**
    * Attaches this request object to a DOM node.
    */
   attachToNode: function(/**Node*/ node)
   {
     let existingData = getEntry(nodeData, node);
     if (typeof existingData == "undefined")
     {
       existingData = {};
       setEntry(nodeData, node, existingData);
     }
 
     // Add this request to the node data
     existingData[this.type + " " + this.location] = this;
   }
 };