Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(488)

Issue 6308119894294528: Issue 2274 - Move notification parsing into a module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 8 months ago
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2274 - Move notification parsing into a module

Patch Set 1 : #

Patch Set 2 : hg mv generateNotifications.py to parser.py #

Patch Set 3 : Don't set the version in parser.load_notifications() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -109 lines) Patch
M sitescripts/management/bin/generateNotifications.py View 1 2 1 chunk +13 lines, -90 lines 0 comments Download
A sitescripts/notifications/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M sitescripts/notifications/parser.py View 1 2 5 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
Split #2162 up a bit, it got too big. Here's the first rather small chunk. ...
4 years, 9 months ago (2015-04-04 23:43:07 UTC) #1
Sebastian Noack
I can't review this patch like that. Please use "hg mv".
4 years, 9 months ago (2015-04-05 11:12:23 UTC) #2
Felix Dahlke
New patch set using hg mv is up. Note that I'm not actually moving generateNotifications.py, ...
4 years, 9 months ago (2015-04-05 16:30:50 UTC) #3
Sebastian Noack
LGTM
4 years, 9 months ago (2015-04-05 16:49:39 UTC) #4
Felix Dahlke
Minor update here: I moved setting the version out of load_notifications() - doesn't really belong ...
4 years, 9 months ago (2015-04-15 09:25:53 UTC) #5
Sebastian Noack
4 years, 9 months ago (2015-04-15 15:10:02 UTC) #6
Still LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5